Re: [PATCH] News: Several apparmor improvements at v6.7.0
Hi Andrea, Thanks for your advice, i'll try again with your suggestions! Jianan Gao On Thu, Nov 12, 2020 at 9:45 PM Andrea Bolognani wrote: > Please don't CC individual developers when posting patches: we're all > subscribed to the mailing list. > > On Mon, 2020-11-09 at 15:33 +0800, jgao wrote: > > From: jgao > > > > Add news about apparmor about the improvements. > > > > Signed-off-by: jgao > > Please make sure both the Signed-off-by tag and git authorship > information are in the form > > FirstName LastName > > We generally can't accept patches that don't have a S-o-b in that > format. > > > + * apparmor: Several improvements > > + > > + Add support for virtiofs filesystem, allowing qemu load old shared > objects after > > + upgrades. > > These are completely distinct changes, but the way you constructed > your sentence makes it appear as if they were connected. I suggest > something like > > Add support for the virtiofs filesystem and allow QEMU to load old > modules after upgrade. > > Does that sound good to you? > > -- > Andrea Bolognani / Red Hat / Virtualization > >
Re: [PATCH] news: Remove one of last two instances of -drive if=none usage
It is just the beginning of the practice to contribute to upstream, can be ignored : ) On Wed, Jul 22, 2020 at 3:30 PM Andrea Bolognani wrote: > On Wed, 2020-07-22 at 07:16 +0200, Peter Krempa wrote: > > On Wed, Jul 22, 2020 at 10:13:16 +0800, Jianan Gao wrote: > > > + * qemu: remove one of last two instances of -drive if=none usage > > > + > > > +Remove one of last two instances of -drive if=none usage to help > QEMU in > > > +deprecation of -drive if=none without the need to refactor all > old boards. > > > > I don't think it's worth documenting this change. It's meant to be > > totally transparent for users. > > Agreed. > > -- > Andrea Bolognani / Red Hat / Virtualization > >
[PATCH] news: Remove one of last two instances of -drive if=none usage
There is a series of patched for describing remove one of last two instances of -drive if=none usage to help QEMU in deprecation of -drive if=none without the need to refactor all old boards. Signed-off-by: Jianan Gao --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ff977968c7..b763e45e11 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -147,6 +147,11 @@ v6.4.0 (2020-06-02) already does in these cases. Users are encouraged to provide complete NUMA topologies to avoid unexpected changes in the domain XML. + * qemu: remove one of last two instances of -drive if=none usage + + Remove one of last two instances of -drive if=none usage to help QEMU in +deprecation of -drive if=none without the need to refactor all old boards. + * **Bug fixes** * qemu: fixed regression in network device hotplug with new qemu versions -- 2.21.3
[PATCH] NEWS: mention readonly attribute is not yet supported by virtiofsd
There was a clear statement on not supported by virtiofsd with readonly attribute. Signed-off-by: Jianan Gao --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2c6c628c61..ff977968c7 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -170,6 +170,10 @@ v6.4.0 (2020-06-02) firewalld resets all iptables rules and chains on restart, and this includes deleting those created by libvirt. + * qemu: reject readonly attribute for virtiofs + +virtiofs does not yet support read-only shares. + v6.3.0 (2020-05-05) === -- 2.21.3
[PATCH] docs/index.html.in: Add knowledge base link and description on index page
Add link and description of libvirt knowledge base to make it easier for users and testers to understand libvirt. Signed-off-by: Jianan Gao --- docs/index.html.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/index.html.in b/docs/index.html.in index 26e8406917..586defff54 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -63,6 +63,9 @@ backup jobs http://wiki.libvirt.org;>Wiki Read further community contributed content + +https://libvirt.org/kbase.html;>Knowledge base +Learn more about libvirt through knowledge base -- 2.21.3
