Re: [PATCH] doc: fix name of file containing max number of VFs
On 7/28/20 7:32 AM, Daniel Henrique Barboza wrote: On 7/28/20 6:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7 +141,7 @@ In this case this device is an SRIOV PF, and the capability element will have a list of address subelements, one for each VF on this PF. If the host system - supports reporting it (via the "sriov_maxvfs" file in the + supports reporting it (via the "sriov_totalvfs" file in the I checked in the Linux kernel and there is no reference to 'sriov_maxvfs'. This means that it's not likely to be something that it's one way in s390x/powerpc but another way in x86. Also, googling 'sriov_maxvfs' gives 3 results only. First result isn't related to a sriov_maxvfs file, the remaining results are links to this Libvirt documentation. So yeah. Late to the party, but as the person who put this typo into the tree, I can verify that it is indeed a typo, and never had any basis in reality. :-P Reviewed-by: Daniel Henrique Barboza device's sysfs directory) the capability element will also have an attribute named maxCount which is the maximum number of SRIOV VFs supported by this device, which
Re: [PATCH] doc: fix name of file containing max number of VFs
s/doc/docs/ in the summary to match the directory prefix On a Tuesday in 2020, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7 +141,7 @@ In this case this device is an SRIOV PF, and the capability element will have a list of address subelements, one for each VF on this PF. If the host system -supports reporting it (via the "sriov_maxvfs" file in the +supports reporting it (via the "sriov_totalvfs" file in the device's sysfs directory) the capability element will also have an attribute named maxCount which is the maximum number of SRIOV VFs supported by this device, which Reviewed-by: Ján Tomko and pushed. Jano signature.asc Description: PGP signature
Re: [PATCH] doc: fix name of file containing max number of VFs
On 7/28/20 11:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7 +141,7 @@ In this case this device is an SRIOV PF, and the capability element will have a list of address subelements, one for each VF on this PF. If the host system -supports reporting it (via the "sriov_maxvfs" file in the +supports reporting it (via the "sriov_totalvfs" file in the device's sysfs directory) the capability element will also have an attribute named maxCount which is the maximum number of SRIOV VFs supported by this device, which Looking into RHEL docs: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_and_managing_virtualization/managing-virtual-devices_configuring-and-managing-virtualization Reviewed-by: Boris Fiuczynski -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
Re: [PATCH] doc: fix name of file containing max number of VFs
On 7/28/20 6:16 AM, Paulo de Rezende Pinatti wrote: Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7 +141,7 @@ In this case this device is an SRIOV PF, and the capability element will have a list of address subelements, one for each VF on this PF. If the host system -supports reporting it (via the "sriov_maxvfs" file in the +supports reporting it (via the "sriov_totalvfs" file in the I checked in the Linux kernel and there is no reference to 'sriov_maxvfs'. This means that it's not likely to be something that it's one way in s390x/powerpc but another way in x86. Also, googling 'sriov_maxvfs' gives 3 results only. First result isn't related to a sriov_maxvfs file, the remaining results are links to this Libvirt documentation. So yeah. Reviewed-by: Daniel Henrique Barboza device's sysfs directory) the capability element will also have an attribute named maxCount which is the maximum number of SRIOV VFs supported by this device, which
[PATCH] doc: fix name of file containing max number of VFs
Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7 +141,7 @@ In this case this device is an SRIOV PF, and the capability element will have a list of address subelements, one for each VF on this PF. If the host system -supports reporting it (via the "sriov_maxvfs" file in the +supports reporting it (via the "sriov_totalvfs" file in the device's sysfs directory) the capability element will also have an attribute named maxCount which is the maximum number of SRIOV VFs supported by this device, which -- 2.26.2
