Re: [PATCH] news: Remove one of last two instances of -drive if=none usage
On Wed, Jul 22, 2020 at 18:18:23 +0800, Jianan Gao wrote: > It is just the beginning of the practice to contribute to upstream, can be That's great! Keep up. > ignored : ) In this case we don't document stuff that is not visible to users in any way. There's a lot of times we refactor stuff which doesn't impact users in any way.
Re: [PATCH] news: Remove one of last two instances of -drive if=none usage
It is just the beginning of the practice to contribute to upstream, can be ignored : ) On Wed, Jul 22, 2020 at 3:30 PM Andrea Bolognani wrote: > On Wed, 2020-07-22 at 07:16 +0200, Peter Krempa wrote: > > On Wed, Jul 22, 2020 at 10:13:16 +0800, Jianan Gao wrote: > > > + * qemu: remove one of last two instances of -drive if=none usage > > > + > > > +Remove one of last two instances of -drive if=none usage to help > QEMU in > > > +deprecation of -drive if=none without the need to refactor all > old boards. > > > > I don't think it's worth documenting this change. It's meant to be > > totally transparent for users. > > Agreed. > > -- > Andrea Bolognani / Red Hat / Virtualization > >
Re: [PATCH] news: Remove one of last two instances of -drive if=none usage
On Wed, 2020-07-22 at 07:16 +0200, Peter Krempa wrote: > On Wed, Jul 22, 2020 at 10:13:16 +0800, Jianan Gao wrote: > > + * qemu: remove one of last two instances of -drive if=none usage > > + > > +Remove one of last two instances of -drive if=none usage to help QEMU > > in > > +deprecation of -drive if=none without the need to refactor all old > > boards. > > I don't think it's worth documenting this change. It's meant to be > totally transparent for users. Agreed. -- Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH] news: Remove one of last two instances of -drive if=none usage
On Wed, Jul 22, 2020 at 10:13:16 +0800, Jianan Gao wrote: > There is a series of patched for describing remove one of last two instances > of -drive if=none usage to help QEMU in deprecation of -drive if=none without > the need to refactor all old boards. > > Signed-off-by: Jianan Gao > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index ff977968c7..b763e45e11 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -147,6 +147,11 @@ v6.4.0 (2020-06-02) > already does in these cases. Users are encouraged to provide complete > NUMA > topologies to avoid unexpected changes in the domain XML. > > + * qemu: remove one of last two instances of -drive if=none usage > + > + Â Remove one of last two instances of -drive if=none usage to help QEMU > in > +deprecation of -drive if=none without the need to refactor all old > boards. I don't think it's worth documenting this change. It's meant to be totally transparent for users.
[PATCH] news: Remove one of last two instances of -drive if=none usage
There is a series of patched for describing remove one of last two instances of -drive if=none usage to help QEMU in deprecation of -drive if=none without the need to refactor all old boards. Signed-off-by: Jianan Gao --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ff977968c7..b763e45e11 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -147,6 +147,11 @@ v6.4.0 (2020-06-02) already does in these cases. Users are encouraged to provide complete NUMA topologies to avoid unexpected changes in the domain XML. + * qemu: remove one of last two instances of -drive if=none usage + + Remove one of last two instances of -drive if=none usage to help QEMU in +deprecation of -drive if=none without the need to refactor all old boards. + * **Bug fixes** * qemu: fixed regression in network device hotplug with new qemu versions -- 2.21.3
