Re: [PATCH] qemu: Remove superfluous breaks

[Ján Tomko]

On a Friday in 2020, Yi Wang wrote:

From: Liao Pingfang 

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---
src/qemu/qemu_firmware.c | 1 -
src/qemu/qemu_hostdev.c  | 1 -
2 files changed, 2 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature

Re: [PATCH] qemu: Remove superfluous breaks

[Daniel Henrique Barboza]

On 7/16/20 11:00 PM, Yi Wang wrote:

From: Liao Pingfang 

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---


Reviewed-by: Daniel Henrique Barboza 


  src/qemu/qemu_firmware.c | 1 -
  src/qemu/qemu_hostdev.c  | 1 -
  2 files changed, 2 deletions(-)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index bd251c0..2edc0ef 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -,7 +,6 @@ qemuFirmwareEnableFeatures(virQEMUDriverPtr driver,
 _("domain has SMM turned off "
   "but chosen firmware requires it"));
  return -1;
-break;
  case VIR_TRISTATE_SWITCH_ABSENT:
  VIR_DEBUG("Enabling SMM feature");
  def->features[VIR_DOMAIN_FEATURE_SMM] = 
VIR_TRISTATE_SWITCH_ON;
diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index fb63da2..d39f9d7 100644
--- a/src/qemu/qemu_hostdev.c
+++ b/src/qemu/qemu_hostdev.c
@@ -202,7 +202,6 @@ 
qemuHostdevPreparePCIDevicesCheckSupport(virDomainHostdevDefPtr *hostdevs,
  virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
 _("host doesn't support legacy PCI passthrough"));
  return false;
-break;
  
  case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN:

  case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST:

[PATCH] qemu: Remove superfluous breaks

[Yi Wang]

From: Liao Pingfang 

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---
 src/qemu/qemu_firmware.c | 1 -
 src/qemu/qemu_hostdev.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index bd251c0..2edc0ef 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -,7 +,6 @@ qemuFirmwareEnableFeatures(virQEMUDriverPtr driver,
_("domain has SMM turned off "
  "but chosen firmware requires it"));
 return -1;
-break;
 case VIR_TRISTATE_SWITCH_ABSENT:
 VIR_DEBUG("Enabling SMM feature");
 def->features[VIR_DOMAIN_FEATURE_SMM] = VIR_TRISTATE_SWITCH_ON;
diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index fb63da2..d39f9d7 100644
--- a/src/qemu/qemu_hostdev.c
+++ b/src/qemu/qemu_hostdev.c
@@ -202,7 +202,6 @@ 
qemuHostdevPreparePCIDevicesCheckSupport(virDomainHostdevDefPtr *hostdevs,
 virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("host doesn't support legacy PCI passthrough"));
 return false;
-break;
 
 case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN:
 case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST:
-- 
2.9.5