Re: [PATCH] qemu_agent: remove unused code

2021-10-27 Thread Ján Tomko

On a Wednesday in 2021, Kristina Hanicova wrote:

Missing commit message.


Signed-off-by: Kristina Hanicova 
---
src/qemu/qemu_agent.c | 11 ---
1 file changed, 11 deletions(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 5f421be6f6..f7feadd5eb 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -237,17 +237,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
return -1;
}

-/*
-for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
-if (STREQ(eventHandlers[i].type, type)) {
-virJSONValue *data = virJSONValueObjectGet(obj, "data");
-VIR_DEBUG("handle %s handler=%p data=%p", type,
-  eventHandlers[i].handler, data);
-(eventHandlers[i].handler)(agent, data);
-break;
-}
-}
-*/


This hunk was introduced by:

commit c160ce3316852a797d7b06b4ee101233866e69a9
CommitDate: 2012-01-24 12:19:51 +0100
QEMU guest agent support

Which also added the following:

/* When you are the first to uncomment this,
 * don't forget to uncomment the corresponding
 * part in qemuAgentIOProcessEvent as well.
 *
static struct {
const char *type;
void (*handler)(qemuAgent *agent, virJSONValue *data);
} eventHandlers[] = {
};
*/

With that deleted as well:

Reviewed-by: Ján Tomko 

Jano


return 0;
}

--
2.31.1



signature.asc
Description: PGP signature


[PATCH] qemu_agent: remove unused code

2021-10-27 Thread Kristina Hanicova
Signed-off-by: Kristina Hanicova 
---
 src/qemu/qemu_agent.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 5f421be6f6..f7feadd5eb 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -237,17 +237,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
 return -1;
 }
 
-/*
-for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
-if (STREQ(eventHandlers[i].type, type)) {
-virJSONValue *data = virJSONValueObjectGet(obj, "data");
-VIR_DEBUG("handle %s handler=%p data=%p", type,
-  eventHandlers[i].handler, data);
-(eventHandlers[i].handler)(agent, data);
-break;
-}
-}
-*/
 return 0;
 }
 
-- 
2.31.1