Re: [PATCH] security: Remove the superfluous break

2020-07-21 Thread Ján Tomko 

On a Friday in 2020, Yi Wang wrote:

From: Liao Pingfang 

Remove the superfuous break, as there is a 'return' before it.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---
src/security/security_apparmor.c | 1 -
1 file changed, 1 deletion(-)



Reviewed-by: Ján Tomko 
and pushed

Jano


signature.asc
Description: PGP signature

Re: [PATCH] security: Remove the superfluous break

2020-07-17 Thread Daniel Henrique Barboza 




On 7/16/20 11:00 PM, Yi Wang wrote:

From: Liao Pingfang 

Remove the superfuous break, as there is a 'return' before it.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---


Reviewed-by: Daniel Henrique Barboza 


  src/security/security_apparmor.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c
index 3f6a213..eea37dc 100644
--- a/src/security/security_apparmor.c
+++ b/src/security/security_apparmor.c
@@ -699,7 +699,6 @@ AppArmorSetMemoryLabel(virSecurityManagerPtr mgr,
  return -1;
  }
  return reload_profile(mgr, def, mem->nvdimmPath, true);
-break;
  case VIR_DOMAIN_MEMORY_MODEL_NONE:
  case VIR_DOMAIN_MEMORY_MODEL_DIMM:
  case VIR_DOMAIN_MEMORY_MODEL_LAST:

[PATCH] security: Remove the superfluous break

2020-07-16 Thread Yi Wang 
From: Liao Pingfang 

Remove the superfuous break, as there is a 'return' before it.

Signed-off-by: Liao Pingfang 
Signed-off-by: Yi Wang 
---
 src/security/security_apparmor.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c
index 3f6a213..eea37dc 100644
--- a/src/security/security_apparmor.c
+++ b/src/security/security_apparmor.c
@@ -699,7 +699,6 @@ AppArmorSetMemoryLabel(virSecurityManagerPtr mgr,
 return -1;
 }
 return reload_profile(mgr, def, mem->nvdimmPath, true);
-break;
 case VIR_DOMAIN_MEMORY_MODEL_NONE:
 case VIR_DOMAIN_MEMORY_MODEL_DIMM:
 case VIR_DOMAIN_MEMORY_MODEL_LAST:
-- 
2.9.5