Re: [PATCH 01/13] qemuxml2xmltest: Add "numatune-distance" test case

2020-06-24 Thread Daniel Henrique Barboza 




On 6/24/20 5:43 PM, Daniel Henrique Barboza wrote:



On 6/24/20 10:48 AM, Michal Privoznik wrote:

This test case tests that expanding of NUMA distances work. On


This first sentence seems odd. Perhaps change it to

"This test case checks that expanding NUMA distance works"





Forgot to add my r-b:


Reviewed-by: Daniel Henrique Barboza

Re: [PATCH 01/13] qemuxml2xmltest: Add "numatune-distance" test case

2020-06-24 Thread Daniel Henrique Barboza 




On 6/24/20 10:48 AM, Michal Privoznik wrote:

This test case tests that expanding of NUMA distances work. On


This first sentence seems odd. Perhaps change it to

"This test case checks that expanding NUMA distance works"





input we accept if only distance from A to B is specified. On the
output we format the B to A distance too.

Signed-off-by: Michal Privoznik 
---
  .../qemuxml2xmloutdata/numatune-distances.xml | 96 +++
  tests/qemuxml2xmltest.c   |  1 +
  2 files changed, 97 insertions(+)
  create mode 100644 tests/qemuxml2xmloutdata/numatune-distances.xml

diff --git a/tests/qemuxml2xmloutdata/numatune-distances.xml 
b/tests/qemuxml2xmloutdata/numatune-distances.xml
new file mode 100644
index 00..48f89cb015
--- /dev/null
+++ b/tests/qemuxml2xmloutdata/numatune-distances.xml
@@ -0,0 +1,96 @@
+
+  QEMUGuest
+  c7a5fdb2-cdaf-9455-926a-d65c16db1809
+  8388608
+  8388608
+  12
+  
+hvm
+
+  
+  
+
+
+
+  
+  
+
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+
+  
+  
+  destroy
+  restart
+  restart
+  
+/usr/bin/qemu-system-x86_64
+
+  
+
+
+
+
+
+  
+
+  
+
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 5a124853b4..d203c97e36 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -1104,6 +1104,7 @@ mymain(void)
  DO_TEST("numatune-auto-prefer", NONE);
  DO_TEST("numatune-memnode", QEMU_CAPS_NUMA, QEMU_CAPS_OBJECT_MEMORY_FILE);
  DO_TEST("numatune-memnode-no-memory", QEMU_CAPS_OBJECT_MEMORY_FILE);
+DO_TEST("numatune-distances", QEMU_CAPS_NUMA, QEMU_CAPS_NUMA_DIST);
  
  DO_TEST("bios-nvram", NONE);

  DO_TEST("bios-nvram-os-interleave", NONE);

[PATCH 01/13] qemuxml2xmltest: Add "numatune-distance" test case

2020-06-24 Thread Michal Privoznik 
This test case tests that expanding of NUMA distances work. On
input we accept if only distance from A to B is specified. On the
output we format the B to A distance too.

Signed-off-by: Michal Privoznik 
---
 .../qemuxml2xmloutdata/numatune-distances.xml | 96 +++
 tests/qemuxml2xmltest.c   |  1 +
 2 files changed, 97 insertions(+)
 create mode 100644 tests/qemuxml2xmloutdata/numatune-distances.xml

diff --git a/tests/qemuxml2xmloutdata/numatune-distances.xml 
b/tests/qemuxml2xmloutdata/numatune-distances.xml
new file mode 100644
index 00..48f89cb015
--- /dev/null
+++ b/tests/qemuxml2xmloutdata/numatune-distances.xml
@@ -0,0 +1,96 @@
+
+  QEMUGuest
+  c7a5fdb2-cdaf-9455-926a-d65c16db1809
+  8388608
+  8388608
+  12
+  
+hvm
+
+  
+  
+
+
+
+  
+  
+
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+  
+
+  
+  
+  
+  
+  
+  
+
+  
+
+  
+  
+  destroy
+  restart
+  restart
+  
+/usr/bin/qemu-system-x86_64
+
+  
+
+
+
+
+
+  
+
+  
+
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 5a124853b4..d203c97e36 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -1104,6 +1104,7 @@ mymain(void)
 DO_TEST("numatune-auto-prefer", NONE);
 DO_TEST("numatune-memnode", QEMU_CAPS_NUMA, QEMU_CAPS_OBJECT_MEMORY_FILE);
 DO_TEST("numatune-memnode-no-memory", QEMU_CAPS_OBJECT_MEMORY_FILE);
+DO_TEST("numatune-distances", QEMU_CAPS_NUMA, QEMU_CAPS_NUMA_DIST);
 
 DO_TEST("bios-nvram", NONE);
 DO_TEST("bios-nvram-os-interleave", NONE);
-- 
2.26.2