Re: [PATCH 09/10] rpc: cleanup virNetDaemonClose method

2020-07-21 Thread Daniel P . Berrangé 
On Tue, Jul 14, 2020 at 12:33:00PM +0300, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy 
> ---
>  src/libvirt_remote.syms |  1 -
>  src/rpc/virnetdaemon.c  | 13 -
>  src/rpc/virnetdaemon.h  |  2 --
>  3 files changed, 16 deletions(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[PATCH 09/10] rpc: cleanup virNetDaemonClose method

2020-07-14 Thread Nikolay Shirokovskiy 
Signed-off-by: Nikolay Shirokovskiy 
---
 src/libvirt_remote.syms |  1 -
 src/rpc/virnetdaemon.c  | 13 -
 src/rpc/virnetdaemon.h  |  2 --
 3 files changed, 16 deletions(-)

diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms
index 0018a0c..2cd1b76 100644
--- a/src/libvirt_remote.syms
+++ b/src/libvirt_remote.syms
@@ -75,7 +75,6 @@ virNetDaemonAddServer;
 virNetDaemonAddShutdownInhibition;
 virNetDaemonAddSignalHandler;
 virNetDaemonAutoShutdown;
-virNetDaemonClose;
 virNetDaemonGetServer;
 virNetDaemonGetServers;
 virNetDaemonHasClients;
diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c
index c4b31c6..87d669c 100644
--- a/src/rpc/virnetdaemon.c
+++ b/src/rpc/virnetdaemon.c
@@ -966,19 +966,6 @@ daemonServerClose(void *payload,
 return 0;
 }
 
-void
-virNetDaemonClose(virNetDaemonPtr dmn)
-{
-if (!dmn)
-return;
-
-virObjectLock(dmn);
-
-virHashForEach(dmn->servers, daemonServerClose, NULL);
-
-virObjectUnlock(dmn);
-}
-
 static int
 daemonServerHasClients(void *payload,
const void *key G_GNUC_UNUSED,
diff --git a/src/rpc/virnetdaemon.h b/src/rpc/virnetdaemon.h
index c2c7767..e708967 100644
--- a/src/rpc/virnetdaemon.h
+++ b/src/rpc/virnetdaemon.h
@@ -73,8 +73,6 @@ void virNetDaemonRun(virNetDaemonPtr dmn);
 
 void virNetDaemonQuit(virNetDaemonPtr dmn);
 
-void virNetDaemonClose(virNetDaemonPtr dmn);
-
 bool virNetDaemonHasClients(virNetDaemonPtr dmn);
 
 virNetServerPtr virNetDaemonGetServer(virNetDaemonPtr dmn,
-- 
1.8.3.1