Re: [PATCH 1/2] vircommand: REPRODUCER: Add artificial timeout before exitting daemonization helper

[Ján Tomko]

On a Tuesday in 2020, Peter Krempa wrote:

Let the intermediate process linger for a moment to reproduce the
sporradic failure in 'commandtest'.
---
src/util/vircommand.c | 1 +
1 file changed, 1 insertion(+)


This breaks commandtest for me:
  TEST: commandtest
   5) Command Exec test4 test   ...
  Offset 163
  Expect [yes]
  Actual [no]
  ... FAILED


diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 5ce69ef241..f6da8b5cf1 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -783,6 +783,7 @@ virExec(virCommandPtr cmd)
 _("Unable to wait for child process"));
_exit(EXIT_FAILURE);
}
+g_usleep(100*1000);
_exit(EXIT_SUCCESS);
}
}


Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature

[PATCH 1/2] vircommand: REPRODUCER: Add artificial timeout before exitting daemonization helper

[Peter Krempa]

Let the intermediate process linger for a moment to reproduce the
sporradic failure in 'commandtest'.
---
 src/util/vircommand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 5ce69ef241..f6da8b5cf1 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -783,6 +783,7 @@ virExec(virCommandPtr cmd)
  _("Unable to wait for child process"));
 _exit(EXIT_FAILURE);
 }
+g_usleep(100*1000);
 _exit(EXIT_SUCCESS);
 }
 }
-- 
2.26.2