Re: [PATCH 12/25] network: make networkDnsmasqXmlNsDef private to bridge_driver.c

[Ján Tomko]

On a Wednesday in 2020, Laine Stump wrote:

This struct isn't used anywhere else.

Signed-off-by: Laine Stump 
---
src/network/bridge_driver.c | 10 ++
src/network/bridge_driver.h |  9 -
2 files changed, 10 insertions(+), 9 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature

[PATCH 12/25] network: make networkDnsmasqXmlNsDef private to bridge_driver.c

[Laine Stump]

This struct isn't used anywhere else.

Signed-off-by: Laine Stump 
---
 src/network/bridge_driver.c | 10 ++
 src/network/bridge_driver.h |  9 -
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index a1b2f5b6c7..275502b778 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -139,6 +139,16 @@ networkDnsmasqCapsRefresh(virNetworkDriverStatePtr driver)
 }
 
 
+extern virXMLNamespace networkDnsmasqXMLNamespace;
+
+typedef struct _networkDnsmasqXmlNsDef networkDnsmasqXmlNsDef;
+typedef networkDnsmasqXmlNsDef *networkDnsmasqXmlNsDefPtr;
+struct _networkDnsmasqXmlNsDef {
+size_t noptions;
+char **options;
+};
+
+
 static void
 networkDnsmasqDefNamespaceFree(void *nsdata)
 {
diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h
index fb0ccad4b1..2613fc629d 100644
--- a/src/network/bridge_driver.h
+++ b/src/network/bridge_driver.h
@@ -27,15 +27,6 @@
 #include "virdnsmasq.h"
 #include "virnetworkobj.h"
 
-extern virXMLNamespace networkDnsmasqXMLNamespace;
-
-typedef struct _networkDnsmasqXmlNsDef networkDnsmasqXmlNsDef;
-typedef networkDnsmasqXmlNsDef *networkDnsmasqXmlNsDefPtr;
-struct _networkDnsmasqXmlNsDef {
-size_t noptions;
-char **options;
-};
-
 virNetworkXMLOptionPtr
 networkDnsmasqCreateXMLConf(void);
 
-- 
2.25.4