Re: [PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

2022-08-08 Thread Paolo Bonzini

On 8/8/22 16:44, Pavel Hrdina wrote:

diff --git 
a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json 
b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
index 31a3905e43..0ee53ae471 100644
--- 
a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
+++ 
b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
@@ -3,74 +3,82 @@
  {
"arch": "ppc",
"current": true,
-  "CPU": 0,
-  "nip": -46116860184chine/unattached/device[2]/thread[0]",
+  "thread-id": 35233
  },

This hunk doesn't look correct and doesn't apply on top of current
master.


Weird, this is not in the file that I have sent.  git send-email or 
sendmail bug?!?


Paolo



Re: [PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

2022-08-08 Thread Pavel Hrdina
On Mon, Aug 08, 2022 at 03:06:04PM +0200, Paolo Bonzini wrote:
> All supported versions of QEMU include the query-cpus-fast QMP command.
> In preparation for dropping support for the old "query-cpus" commands,
> convert the JSON output for PPC tests to the new format, and drop the
> "halted" field from the expected output as it is not available anymore.
> 
> The CPU properties were obtained from the query-hotpluggable-cpus output
> in tests/qemumonitorjsondata.  CPU, thread_id, and qom_path are renamed
> respectively to cpu-index, qom-path and thread-id, while nip and halted
> are removed.
> 
> Signed-off-by: Paolo Bonzini 
> ---
>  ...umonitorjson-cpuinfo-ppc64-basic-cpus.json |  64 ++---
>  ...itorjson-cpuinfo-ppc64-hotplug-1-cpus.json | 176 ++--
>  ...itorjson-cpuinfo-ppc64-hotplug-2-cpus.json | 264 ++
>  ...itorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 264 ++
>  ...mumonitorjson-cpuinfo-ppc64-hotplug-4.data |   8 -
>  ...torjson-cpuinfo-ppc64-no-threads-cpus.json |  88 +++---
>  tests/qemumonitorjsontest.c   |  10 +-
>  7 files changed, 461 insertions(+), 413 deletions(-)

[...]

> diff --git 
> a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
>  
> b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
> index 31a3905e43..0ee53ae471 100644
> --- 
> a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
> +++ 
> b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json
> @@ -3,74 +3,82 @@
>  {
>"arch": "ppc",
>"current": true,
> -  "CPU": 0,
> -  "nip": -46116860184chine/unattached/device[2]/thread[0]",
> +  "thread-id": 35233
>  },

This hunk doesn't look correct and doesn't apply on top of current
master.

Otherwise looks good.


signature.asc
Description: PGP signature


[PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

2022-08-08 Thread Paolo Bonzini
All supported versions of QEMU include the query-cpus-fast QMP command.
In preparation for dropping support for the old "query-cpus" commands,
convert the JSON output for PPC tests to the new format, and drop the
"halted" field from the expected output as it is not available anymore.

The CPU properties were obtained from the query-hotpluggable-cpus output
in tests/qemumonitorjsondata.  CPU, thread_id, and qom_path are renamed
respectively to cpu-index, qom-path and thread-id, while nip and halted
are removed.

Signed-off-by: Paolo Bonzini 
---
 ...umonitorjson-cpuinfo-ppc64-basic-cpus.json |  64 ++---
 ...itorjson-cpuinfo-ppc64-hotplug-1-cpus.json | 176 ++--
 ...itorjson-cpuinfo-ppc64-hotplug-2-cpus.json | 264 ++
 ...itorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 264 ++
 ...mumonitorjson-cpuinfo-ppc64-hotplug-4.data |   8 -
 ...torjson-cpuinfo-ppc64-no-threads-cpus.json |  88 +++---
 tests/qemumonitorjsontest.c   |  10 +-
 7 files changed, 461 insertions(+), 413 deletions(-)

diff --git 
a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-basic-cpus.json 
b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-basic-cpus.json
index 27a3d8b89f..d1d3406958 100644
--- a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-basic-cpus.json
+++ b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-basic-cpus.json
@@ -3,74 +3,58 @@
 {
   "arch": "ppc",
   "current": true,
-  "CPU": 0,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[0]",
-  "halted": false,
-  "thread_id": 21925
+  "cpu-index": 0,
+  "qom-path": "/machine/unattached/device[1]/thread[0]",
+  "thread-id": 21925
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 1,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[1]",
-  "halted": false,
-  "thread_id": 21926
+  "cpu-index": 1,
+  "qom-path": "/machine/unattached/device[1]/thread[1]",
+  "thread-id": 21926
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 2,
-  "nip": -4611686018422360608,
-  "qom_path": "/machine/unattached/device[1]/thread[2]",
-  "halted": false,
-  "thread_id": 21927
+  "cpu-index": 2,
+  "qom-path": "/machine/unattached/device[1]/thread[2]",
+  "thread-id": 21927
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 3,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[3]",
-  "halted": false,
-  "thread_id": 21928
+  "cpu-index": 3,
+  "qom-path": "/machine/unattached/device[1]/thread[3]",
+  "thread-id": 21928
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 4,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[4]",
-  "halted": false,
-  "thread_id": 21930
+  "cpu-index": 4,
+  "qom-path": "/machine/unattached/device[1]/thread[4]",
+  "thread-id": 21930
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 5,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[5]",
-  "halted": false,
-  "thread_id": 21931
+  "cpu-index": 5,
+  "qom-path": "/machine/unattached/device[1]/thread[5]",
+  "thread-id": 21931
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 6,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[6]",
-  "halted": false,
-  "thread_id": 21932
+  "cpu-index": 6,
+  "qom-path": "/machine/unattached/device[1]/thread[6]",
+  "thread-id": 21932
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 7,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[7]",
-  "halted": false,
-  "thread_id": 21933
+  "cpu-index": 7,
+  "qom-path": "/machine/unattached/device[1]/thread[7]",
+  "thread-id": 21933
 }
   ],
   "id": "libvirt-12"
diff --git 
a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-hotplug-1-cpus.json 
b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-hotplug-1-cpus.json
index 7771cbc636..1516ccb99f 100644
--- 
a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-hotplug-1-cpus.json
+++ 
b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-hotplug-1-cpus.json
@@ -3,146 +3,162 @@
 {
   "arch": "ppc",
   "current": true,
-  "CPU": 0,
-  "nip": -4611686018426772172,
-  "qom_path": "/machine/unattached/device[1]/thread[0]",
-  "halted": false,
-  "thread_id": 21925
+  "cpu-index": 0,
+  "props": {
+"core-id": 0
+  },
+  "qom-path": "/machine/unattached/device[1]/thread[0]",
+  "thread-id": 21925
 },
 {
   "arch": "ppc",
   "current": false,
-  "CPU": 1,
-