Re: [PATCH 39/80] qemu: block: Remove unused qemuBlockGetNodeData

2022-08-05 Thread Pavel Hrdina
On Tue, Jul 26, 2022 at 04:37:17PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_block.c | 40 
>  src/qemu/qemu_block.h |  3 ---
>  2 files changed, 43 deletions(-)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature


[PATCH 39/80] qemu: block: Remove unused qemuBlockGetNodeData

2022-07-26 Thread Peter Krempa
Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_block.c | 40 
 src/qemu/qemu_block.h |  3 ---
 2 files changed, 43 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index ea0b783bbb..6e643598bc 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -52,46 +52,6 @@ qemuBlockNodeNameValidate(const char *nn)
 }


-static int
-qemuBlockNamedNodesArrayToHash(size_t pos G_GNUC_UNUSED,
-   virJSONValue *item,
-   void *opaque)
-{
-GHashTable *table = opaque;
-const char *name;
-
-if (!(name = virJSONValueObjectGetString(item, "node-name")))
-return 1;
-
-if (virHashAddEntry(table, name, item) < 0)
-return -1;
-
-return 0;
-}
-
-
-/**
- * qemuBlockGetNodeData:
- * @data: JSON object returned from query-named-block-nodes
- *
- * Returns a hash table organized by the node name of the JSON value objects of
- * data for given qemu block nodes.
- *
- * Returns a filled GHashTable *on success NULL on error.
- */
-GHashTable *
-qemuBlockGetNodeData(virJSONValue *data)
-{
-g_autoptr(GHashTable) nodedata = virHashNew(virJSONValueHashFree);
-
-if (virJSONValueArrayForeachSteal(data,
-  qemuBlockNamedNodesArrayToHash, 
nodedata) < 0)
-return NULL;
-
-return g_steal_pointer();
-}
-
-
 /**
  * qemuBlockStorageSourceSupportsConcurrentAccess:
  * @src: disk storage source
diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h
index 134ce41dd5..422c1a0deb 100644
--- a/src/qemu/qemu_block.h
+++ b/src/qemu/qemu_block.h
@@ -39,9 +39,6 @@ struct qemuBlockNodeNameBackingChainData {
 char *drvstorage;
 };

-GHashTable *
-qemuBlockGetNodeData(virJSONValue *data);
-
 bool
 qemuBlockStorageSourceSupportsConcurrentAccess(virStorageSource *src);

-- 
2.36.1