Re: [PATCH 55/80] qemu: driver: Remove remaining QEMU_CAPS_BLOCKDEV capability checks

[Pavel Hrdina]

On Tue, Jul 26, 2022 at 04:37:33PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_driver.c | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature

[PATCH 55/80] qemu: driver: Remove remaining QEMU_CAPS_BLOCKDEV capability checks

[Peter Krempa]

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_driver.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 59d1caa053..1ecc9a71b3 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9992,9 +9992,7 @@ qemuDomainBlockResize(virDomainPtr dom,
 goto endjob;
 }

-if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) &&
-!qemuDiskBusIsSD(disk->bus)) {
-
+if (!qemuDiskBusIsSD(disk->bus)) {
 nodename = disk->src->nodeformat;
 } else {
 if (!(device = qemuAliasDiskDriveFromDisk(disk)))
@@ -16218,8 +16216,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
 /* blockdev-based qemu doesn't want to set the throttling when a cdrom
  * is empty. Skip the monitor call here since we will set the 
throttling
  * once new media is inserted */
-if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) ||
-!virStorageSourceIsEmpty(disk->src)) {
+if (!virStorageSourceIsEmpty(disk->src)) {
 int rc = 0;

 qemuDomainObjEnterMonitor(driver, vm);
-- 
2.36.1