Re: [PATCH 74/80] qemuDomainDetermineDiskChain: Assume QEMU_CAPS_BLOCKDEV

[Pavel Hrdina]

On Tue, Jul 26, 2022 at 04:37:52PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_domain.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature

[PATCH 74/80] qemuDomainDetermineDiskChain: Assume QEMU_CAPS_BLOCKDEV

[Peter Krempa]

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_domain.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 8ac99a8cf7..d372381c74 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7635,8 +7635,6 @@ qemuDomainDetermineDiskChain(virQEMUDriver *driver,
 virStorageSource *src; /* iterator for the backing chain declared in XML */
 virStorageSource *n; /* iterator for the backing chain detected from disk 
*/
 qemuDomainObjPrivate *priv = vm->privateData;
-bool blockdev = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV);
-bool isSD = qemuDiskBusIsSD(disk->bus);
 uid_t uid;
 gid_t gid;

@@ -7726,7 +7724,7 @@ qemuDomainDetermineDiskChain(virQEMUDriver *driver,
 qemuDomainPrepareStorageSourceConfig(n, cfg);
 qemuDomainPrepareDiskSourceData(disk, n);

-if (blockdev && !isSD &&
+if (!qemuDiskBusIsSD(disk->bus) &&
 qemuDomainPrepareStorageSourceBlockdev(disk, n, priv, cfg) < 0)
 return -1;
 }
-- 
2.36.1