Re: [PATCH libvirt v2 10/11] node_device: mdev matrix support
On 11/12/20 9:42 PM, Jonathon Jongsma wrote: On Thu, 12 Nov 2020 13:15:18 +0100 Shalini Chellathurai Saroja wrote: Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 65c647f5..e254b492 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -662,6 +662,10 @@ nodeDeviceFindAddressByName(const char *name) break; } +case VIR_NODE_DEV_CAP_AP_MATRIX: +addr = g_strdup(caps->data.ap_matrix.addr); +break; + case VIR_NODE_DEV_CAP_SYSTEM: case VIR_NODE_DEV_CAP_USB_DEV: case VIR_NODE_DEV_CAP_USB_INTERFACE: @@ -680,7 +684,6 @@ nodeDeviceFindAddressByName(const char *name) case VIR_NODE_DEV_CAP_VDPA: case VIR_NODE_DEV_CAP_AP_CARD: case VIR_NODE_DEV_CAP_AP_QUEUE: -case VIR_NODE_DEV_CAP_AP_MATRIX: case VIR_NODE_DEV_CAP_LAST: break; } So here is where you use the saved address field. Perhaps the field should be introduced in this patch instead? ok, I will do so. -- Kind regards Shalini Chellathurai Saroja Linux on Z and Virtualization Development Vorsitzende des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
Re: [PATCH libvirt v2 10/11] node_device: mdev matrix support
On Thu, 12 Nov 2020 13:15:18 +0100 Shalini Chellathurai Saroja wrote: > Allow mdev devices to be created on the matrix device. > > Signed-off-by: Shalini Chellathurai Saroja > Reviewed-by: Bjoern Walk > Reviewed-by: Boris Fiuczynski > --- > src/node_device/node_device_driver.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/node_device/node_device_driver.c > b/src/node_device/node_device_driver.c index 65c647f5..e254b492 100644 > --- a/src/node_device/node_device_driver.c > +++ b/src/node_device/node_device_driver.c > @@ -662,6 +662,10 @@ nodeDeviceFindAddressByName(const char *name) > break; > } > > +case VIR_NODE_DEV_CAP_AP_MATRIX: > +addr = g_strdup(caps->data.ap_matrix.addr); > +break; > + > case VIR_NODE_DEV_CAP_SYSTEM: > case VIR_NODE_DEV_CAP_USB_DEV: > case VIR_NODE_DEV_CAP_USB_INTERFACE: > @@ -680,7 +684,6 @@ nodeDeviceFindAddressByName(const char *name) > case VIR_NODE_DEV_CAP_VDPA: > case VIR_NODE_DEV_CAP_AP_CARD: > case VIR_NODE_DEV_CAP_AP_QUEUE: > -case VIR_NODE_DEV_CAP_AP_MATRIX: > case VIR_NODE_DEV_CAP_LAST: > break; > } So here is where you use the saved address field. Perhaps the field should be introduced in this patch instead?
[PATCH libvirt v2 10/11] node_device: mdev matrix support
Allow mdev devices to be created on the matrix device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 65c647f5..e254b492 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -662,6 +662,10 @@ nodeDeviceFindAddressByName(const char *name) break; } +case VIR_NODE_DEV_CAP_AP_MATRIX: +addr = g_strdup(caps->data.ap_matrix.addr); +break; + case VIR_NODE_DEV_CAP_SYSTEM: case VIR_NODE_DEV_CAP_USB_DEV: case VIR_NODE_DEV_CAP_USB_INTERFACE: @@ -680,7 +684,6 @@ nodeDeviceFindAddressByName(const char *name) case VIR_NODE_DEV_CAP_VDPA: case VIR_NODE_DEV_CAP_AP_CARD: case VIR_NODE_DEV_CAP_AP_QUEUE: -case VIR_NODE_DEV_CAP_AP_MATRIX: case VIR_NODE_DEV_CAP_LAST: break; } -- 2.26.2
