Re: [PATCH v2 01/17] virfdstream: Use g_autofree in virFDStreamThreadDoRead()

[Peter Krempa]

On Tue, Jul 07, 2020 at 21:46:19 +0200, Michal Privoznik wrote:
> The buffer that allocated in the virFDStreamThreadDoRead() can be
> automatically freed, or if saved into the message structure it
> can be stolen.
> 
> Signed-off-by: Michal Privoznik 
> ---
>  src/util/virfdstream.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa 

[PATCH v2 01/17] virfdstream: Use g_autofree in virFDStreamThreadDoRead()

[Michal Privoznik]

The buffer that allocated in the virFDStreamThreadDoRead() can be
automatically freed, or if saved into the message structure it
can be stolen.

Signed-off-by: Michal Privoznik 
---
 src/util/virfdstream.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/util/virfdstream.c b/src/util/virfdstream.c
index 1c32be47a9..e29c95690b 100644
--- a/src/util/virfdstream.c
+++ b/src/util/virfdstream.c
@@ -431,7 +431,7 @@ virFDStreamThreadDoRead(virFDStreamDataPtr fdst,
 virFDStreamMsgPtr msg = NULL;
 int inData = 0;
 long long sectionLen = 0;
-char *buf = NULL;
+g_autofree char *buf = NULL;
 ssize_t got;
 
 if (sparse && *dataLen == 0) {
@@ -483,9 +483,8 @@ virFDStreamThreadDoRead(virFDStreamDataPtr fdst,
 }
 
 msg->type = VIR_FDSTREAM_MSG_TYPE_DATA;
-msg->stream.data.buf = buf;
+msg->stream.data.buf = g_steal_pointer();
 msg->stream.data.len = got;
-buf = NULL;
 if (sparse)
 *dataLen -= got;
 }
@@ -496,7 +495,6 @@ virFDStreamThreadDoRead(virFDStreamDataPtr fdst,
 return got;
 
  error:
-VIR_FREE(buf);
 virFDStreamMsgFree(msg);
 return -1;
 }
-- 
2.26.2