Re: [PATCH v2 07/29] qemu_domain.c: disable default devices for PowerNV machines

2022-02-21 Thread Ján Tomko

On a Tuesday in 2022, Daniel Henrique Barboza wrote:

PowerNV domains will support pcie-root devices as PHBs, in a similar
fashion as pSeries domains supports the spapr-pci-host-bridge as a
pci-root model.

Set 'addPCIRoot' to false since we'll not be using this buses in this
machine. 'addDefaultMemballoon' is also set to false since the balloon
driver wasn't really tested with the PowerNV kernel.

Reviewed-by: Peter Krempa 
Signed-off-by: Daniel Henrique Barboza 
---
src/qemu/qemu_domain.c | 9 +
1 file changed, 9 insertions(+)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature


[PATCH v2 07/29] qemu_domain.c: disable default devices for PowerNV machines

2022-01-25 Thread Daniel Henrique Barboza
PowerNV domains will support pcie-root devices as PHBs, in a similar
fashion as pSeries domains supports the spapr-pci-host-bridge as a
pci-root model.

Set 'addPCIRoot' to false since we'll not be using this buses in this
machine. 'addDefaultMemballoon' is also set to false since the balloon
driver wasn't really tested with the PowerNV kernel.

Reviewed-by: Peter Krempa 
Signed-off-by: Daniel Henrique Barboza 
---
 src/qemu/qemu_domain.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 1b4b293388..89dbc20eee 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -3670,6 +3670,15 @@ qemuDomainDefAddDefaultDevices(virQEMUDriver *driver,
  * add the definition if not already present */
 if (qemuDomainIsPSeries(def))
 addPanicDevice = true;
+
+if (qemuDomainIsPowerNV(def)) {
+addPCIRoot = false;
+addDefaultUSB = false;
+addDefaultUSBKBD = false;
+addDefaultUSBMouse = false;
+addDefaultMemballoon = false;
+}
+
 break;
 
 case VIR_ARCH_ALPHA:
-- 
2.34.1