Re: [libvirt] [PATCH] Disable building of static Python module.

2010-01-06 Thread Daniel Veillard
On Wed, Dec 23, 2009 at 07:07:48PM +0100, Diego Elio Pettenò wrote:
 Python modules are loaded at runtime so the static version of it is not
 really needed, this avoids duplicating the build for the PIC and non-PIC
 cases.
 ---
  python/Makefile.am |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/python/Makefile.am b/python/Makefile.am
 index 04342b7..58c6729 100644
 --- a/python/Makefile.am
 +++ b/python/Makefile.am
 @@ -39,7 +39,7 @@ libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c 
 libvirt.c libvirt.h
  # need extra flags here
  libvirtmod_la_CFLAGS = @WARN_PYTHON_CFLAGS@
  
 -libvirtmod_la_LDFLAGS = -module -avoid-version -L$(top_builddir)/src/.libs \
 +libvirtmod_la_LDFLAGS = -module -avoid-version -shared 
 -L$(top_builddir)/src/.libs \
   @CYGWIN_EXTRA_LDFLAGS@
  libvirtmod_la_LIBADD = $(mylibs) \
   @CYGWIN_EXTRA_LIBADD@ @CYGWIN_EXTRA_PYTHON_LIBADD@

  Okay, makes sense to me, applied,

   thanks !

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH] Disable building of static Python module.

2009-12-23 Thread Diego Elio Pettenò
Python modules are loaded at runtime so the static version of it is not
really needed, this avoids duplicating the build for the PIC and non-PIC
cases.
---
 python/Makefile.am |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/python/Makefile.am b/python/Makefile.am
index 04342b7..58c6729 100644
--- a/python/Makefile.am
+++ b/python/Makefile.am
@@ -39,7 +39,7 @@ libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c 
libvirt.c libvirt.h
 # need extra flags here
 libvirtmod_la_CFLAGS = @WARN_PYTHON_CFLAGS@
 
-libvirtmod_la_LDFLAGS = -module -avoid-version -L$(top_builddir)/src/.libs \
+libvirtmod_la_LDFLAGS = -module -avoid-version -shared 
-L$(top_builddir)/src/.libs \
@CYGWIN_EXTRA_LDFLAGS@
 libvirtmod_la_LIBADD = $(mylibs) \
@CYGWIN_EXTRA_LIBADD@ @CYGWIN_EXTRA_PYTHON_LIBADD@
-- 
1.6.6.rc4

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list