Re: [libvirt] [PATCH] Fix build on Mingw32 wrt export of virNetServerGetDBusConn

2011-11-21 Thread Eric Blake
On 11/21/2011 04:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" 
> 
> Mingw32 complains if you request export of a symbol which does
> not in fact exist.
> 
> * src/libvirt_bridge.syms, src/libvirt_macvtap.syms: Delete
>   obsolete files
> * src/libvirt_private.syms: Remove virNetServerGetDBusConn
> * src/libvirt_dbus.syms: Add virNetServerGetDBusConn

ACK.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Fix build on Mingw32 wrt export of virNetServerGetDBusConn

2011-11-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" 

Mingw32 complains if you request export of a symbol which does
not in fact exist.

* src/libvirt_bridge.syms, src/libvirt_macvtap.syms: Delete
  obsolete files
* src/libvirt_private.syms: Remove virNetServerGetDBusConn
* src/libvirt_dbus.syms: Add virNetServerGetDBusConn
---
 src/Makefile.am  |8 ++--
 src/libvirt_bridge.syms  |   23 ---
 src/libvirt_dbus.syms|2 ++
 src/libvirt_macvtap.syms |   10 --
 src/libvirt_private.syms |1 -
 5 files changed, 4 insertions(+), 40 deletions(-)
 delete mode 100644 src/libvirt_bridge.syms
 create mode 100644 src/libvirt_dbus.syms
 delete mode 100644 src/libvirt_macvtap.syms

diff --git a/src/Makefile.am b/src/Makefile.am
index f82be78..2ee42a1 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1175,16 +1175,12 @@ if WITH_DRIVER_MODULES
 USED_SYM_FILES += libvirt_driver_modules.syms
 endif
 
-if WITH_BRIDGE
-USED_SYM_FILES += libvirt_bridge.syms
-endif
-
 if WITH_LINUX
 USED_SYM_FILES += libvirt_linux.syms
 endif
 
-if WITH_MACVTAP
-USED_SYM_FILES += libvirt_macvtap.syms
+if HAVE_DBUS
+USED_SYM_FILES += libvirt_dbus.syms
 endif
 
 if WITH_LIBVIRTD
diff --git a/src/libvirt_bridge.syms b/src/libvirt_bridge.syms
deleted file mode 100644
index 626f6ee..000
--- a/src/libvirt_bridge.syms
+++ /dev/null
@@ -1,23 +0,0 @@
-#
-# These symbols are dependent upon --with-qemu or --with-lxc via
-# WITH_BRIDGE.
-#
-
-
-# bridge.h
-brAddBridge;
-brAddInetAddress;
-brAddInterface;
-brAddTap;
-brCreateTap;
-brDelInetAddress;
-brDeleteBridge;
-brDeleteTap;
-brHasBridge;
-brInit;
-brSetEnableSTP;
-brSetForwardDelay;
-brSetInetNetmask;
-brSetInterfaceMac;
-brSetInterfaceUp;
-brShutdown;
diff --git a/src/libvirt_dbus.syms b/src/libvirt_dbus.syms
new file mode 100644
index 000..a460ec5
--- /dev/null
+++ b/src/libvirt_dbus.syms
@@ -0,0 +1,2 @@
+# virnetserver.h
+virNetServerGetDBusConn;
diff --git a/src/libvirt_macvtap.syms b/src/libvirt_macvtap.syms
deleted file mode 100644
index b48565b..000
--- a/src/libvirt_macvtap.syms
+++ /dev/null
@@ -1,10 +0,0 @@
-#
-# These symbols are dependent on WITH_MACVTAP.
-#
-
-
-# macvtap.h
-delMacvtap;
-openMacvtapTap;
-vpAssociatePortProfileId;
-vpDisassociatePortProfileId;
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 7906f5d..f4e25c1 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1252,7 +1252,6 @@ virNetServerAddSignalHandler;
 virNetServerAutoShutdown;
 virNetServerClose;
 virNetServerFree;
-virNetServerGetDBusConn;
 virNetServerIsPrivileged;
 virNetServerNew;
 virNetServerQuit;
-- 
1.7.6.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list