[libvirt] [PATCH] Fix build with polkit0
Commit 8dd623b9 introduced a build error with --enable-compile-warnings=error remote.c:2593: error: unused variable 'rv' [-Wunused-variable] Pushing under build-breaker rule. --- daemon/remote.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 724db23..ed27053 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -2590,7 +2590,6 @@ remoteDispatchAuthPolkit(virNetServerPtr server, DBusError err; const char *action; char *ident = NULL; -int rv = -1; struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client); -- 1.7.7 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix build with polkit0
On Tue, Nov 15, 2011 at 03:39:28PM -0700, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- daemon/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e8c47ae..59db217 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -156,6 +156,10 @@ endif if WITH_NWFILTER libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la endif + +if HAVE_POLKIT0 +libvirtd_LDADD += ../src/libvirt_driver_remote.la +endif NACK this is wrong - it is already linked to libvirt.so, which is linked to libvirtd, so tthis results in 2 copies of the code linked. What is missing here is likely the entry for virNetServerGetDBusConn in libvirt_private.syms Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix build with polkit0
Daniel P. Berrange wrote: On Tue, Nov 15, 2011 at 03:39:28PM -0700, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- daemon/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e8c47ae..59db217 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -156,6 +156,10 @@ endif if WITH_NWFILTER libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la endif + +if HAVE_POLKIT0 +libvirtd_LDADD += ../src/libvirt_driver_remote.la +endif NACK this is wrong - it is already linked to libvirt.so, which is linked to libvirtd, so tthis results in 2 copies of the code linked. What is missing here is likely the entry for virNetServerGetDBusConn in libvirt_private.syms Opps, I committed it after Eric's ACK. I'll revert and submit a proper fix - after some meetings :(. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix build with polkit0
I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- daemon/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e8c47ae..59db217 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -156,6 +156,10 @@ endif if WITH_NWFILTER libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la endif + +if HAVE_POLKIT0 +libvirtd_LDADD += ../src/libvirt_driver_remote.la +endif endif libvirtd_LDADD += ../src/libvirt.la -- 1.7.7 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix build with polkit0
On 11/15/2011 03:39 PM, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- daemon/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e8c47ae..59db217 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -156,6 +156,10 @@ endif if WITH_NWFILTER libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la endif + +if HAVE_POLKIT0 +libvirtd_LDADD += ../src/libvirt_driver_remote.la +endif endif ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix build with polkit0
Eric Blake wrote: On 11/15/2011 03:39 PM, Jim Fehlig wrote: I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- daemon/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e8c47ae..59db217 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -156,6 +156,10 @@ endif if WITH_NWFILTER libvirtd_LDADD += ../src/libvirt_driver_nwfilter.la endif + +if HAVE_POLKIT0 +libvirtd_LDADD += ../src/libvirt_driver_remote.la +endif endif ACK. Thanks, pushed. Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list