Re: [libvirt] [PATCH] Fix minor typos in messages and docs
From 89a859c1229283cdb8d8e877ee1a81972f7e5af1 Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Tue, 4 Dec 2018 19:08:14 +0200 Subject: [PATCH] Fix minor typos in messages and docs Signed-off-by: Yuri Chornoivan --- config-post.h | 2 +- include/libvirt/libvirt-event.h| 2 +- src/access/viraccessperm.h | 4 ++-- src/bhyve/bhyve_command.c | 2 +- src/conf/domain_addr.c | 4 ++-- src/conf/object_event.c| 2 +- src/conf/virstorageobj.c | 2 +- src/driver.h | 2 +- src/hyperv/hyperv_wmi_generator.py | 20 ++-- src/libvirt-domain.c | 6 +++--- src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_migration.c| 2 +- src/lxc/lxc_conf.c | 2 +- src/nwfilter/nwfilter_gentech_driver.c | 2 +- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_domain.c | 6 +++--- src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_hotplug.c| 2 +- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_monitor.c| 2 +- src/qemu/qemu_monitor_json.c | 6 +++--- src/qemu/qemu_process.c| 2 +- src/qemu/qemu_security.c | 2 +- src/security/virt-aa-helper.c | 2 +- src/storage/storage_backend_disk.c | 2 +- src/uml/uml_conf.c | 2 +- src/util/viralloc.c| 2 +- src/util/viralloc.h| 2 +- src/util/virbitmap.c | 2 +- src/util/vircgroup.c | 4 ++-- src/util/vircrypto.c | 4 ++-- src/util/virlog.c | 2 +- src/util/virmodule.c | 2 +- src/util/virnetdevbandwidth.c | 2 +- src/util/virnetdevip.c | 2 +- src/util/virnetdevmacvlan.c| 2 +- src/util/virnetdevopenvswitch.c| 2 +- src/util/virrandom.c | 2 +- src/util/virresctrl.c | 2 +- src/util/virstoragefile.h | 2 +- src/util/virstring.c | 6 +++--- src/vbox/vbox_network.c| 2 +- src/vbox/vbox_uniformed_api.h | 4 ++-- src/vmx/vmx.c | 8 src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c| 2 +- src/xenconfig/xen_sxpr.c | 8 tests/securityselinuxlabeltest.c | 2 +- tests/virfirewalltest.c| 20 ++-- tests/virhashtest.c| 2 +- tests/virmock.h| 2 +- tests/virtestmock.c| 2 +- tools/virsh.c | 2 +- tools/virt-admin.c | 2 +- tools/vsh-table.c | 2 +- 57 files changed, 95 insertions(+), 95 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index cb6901d9bf..cc099436dc 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -277,7 +277,7 @@ virLogOnceInit(void) * it might not be possible to load NSS modules via getaddrinfo() * (e.g. at container startup the host filesystem will not be * accessible anymore. - * Must not use virGetHostname though as that causes re-entrancy + * Must not use virGetHostname though as that causes re-entrance * problems if it triggers logging codepaths */ r = gethostname(virLogHostname, sizeof(virLogHostname)); Reentrancy is a word: https://en.wikipedia.org/wiki/Reentrancy_(computing) I dropped this hunk. Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix minor typos in messages and docs
Hi,
Please find the attached patch with minor fixes.
Many thanks in advance for reviewing it.
Best regards,
Yuri>From 89a859c1229283cdb8d8e877ee1a81972f7e5af1 Mon Sep 17 00:00:00 2001
From: Yuri Chornoivan
Date: Tue, 4 Dec 2018 19:08:14 +0200
Subject: [PATCH] Fix minor typos in messages and docs
Signed-off-by: Yuri Chornoivan
---
config-post.h | 2 +-
include/libvirt/libvirt-event.h| 2 +-
src/access/viraccessperm.h | 4 ++--
src/bhyve/bhyve_command.c | 2 +-
src/conf/domain_addr.c | 4 ++--
src/conf/object_event.c| 2 +-
src/conf/virstorageobj.c | 2 +-
src/driver.h | 2 +-
src/hyperv/hyperv_wmi_generator.py | 20 ++--
src/libvirt-domain.c | 6 +++---
src/libxl/libxl_conf.c | 2 +-
src/libxl/libxl_migration.c| 2 +-
src/lxc/lxc_conf.c | 2 +-
src/nwfilter/nwfilter_gentech_driver.c | 2 +-
src/phyp/phyp_driver.c | 2 +-
src/qemu/qemu_block.c | 2 +-
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_domain.c | 6 +++---
src/qemu/qemu_driver.c | 4 ++--
src/qemu/qemu_hotplug.c| 2 +-
src/qemu/qemu_migration.c | 2 +-
src/qemu/qemu_monitor.c| 2 +-
src/qemu/qemu_monitor_json.c | 6 +++---
src/qemu/qemu_process.c| 2 +-
src/qemu/qemu_security.c | 2 +-
src/security/virt-aa-helper.c | 2 +-
src/storage/storage_backend_disk.c | 2 +-
src/uml/uml_conf.c | 2 +-
src/util/viralloc.c| 2 +-
src/util/viralloc.h| 2 +-
src/util/virbitmap.c | 2 +-
src/util/vircgroup.c | 4 ++--
src/util/vircrypto.c | 4 ++--
src/util/virlog.c | 2 +-
src/util/virmodule.c | 2 +-
src/util/virnetdevbandwidth.c | 2 +-
src/util/virnetdevip.c | 2 +-
src/util/virnetdevmacvlan.c| 2 +-
src/util/virnetdevopenvswitch.c| 2 +-
src/util/virrandom.c | 2 +-
src/util/virresctrl.c | 2 +-
src/util/virstoragefile.h | 2 +-
src/util/virstring.c | 6 +++---
src/vbox/vbox_network.c| 2 +-
src/vbox/vbox_uniformed_api.h | 4 ++--
src/vmx/vmx.c | 8
src/vz/vz_driver.c | 2 +-
src/vz/vz_sdk.c| 2 +-
src/xenconfig/xen_sxpr.c | 8
tests/securityselinuxlabeltest.c | 2 +-
tests/virfirewalltest.c| 20 ++--
tests/virhashtest.c| 2 +-
tests/virmock.h| 2 +-
tests/virtestmock.c| 2 +-
tools/virsh.c | 2 +-
tools/virt-admin.c | 2 +-
tools/vsh-table.c | 2 +-
57 files changed, 95 insertions(+), 95 deletions(-)
diff --git a/config-post.h b/config-post.h
index 063e30fa37..dd4ef8fc0b 100644
--- a/config-post.h
+++ b/config-post.h
@@ -19,7 +19,7 @@
/*
* Since virt-login-shell will be setuid, we must do everything
* we can to avoid linking to other libraries. Many of them do
- * unsafe things in functions marked __atttribute__((constructor)).
+ * unsafe things in functions marked __attribute__((constructor)).
* The only way to avoid such deps is to re-compile the
* functions with the code in question disabled, and for that we
* must override the main config.h rules. Hence this file :-(
diff --git a/include/libvirt/libvirt-event.h b/include/libvirt/libvirt-event.h
index 23227d0901..838cb54878 100644
--- a/include/libvirt/libvirt-event.h
+++ b/include/libvirt/libvirt-event.h
@@ -60,7 +60,7 @@ typedef void (*virEventHandleCallback)(int watch, int fd, int events, void *opaq
* virEventAddHandleFunc:
* @fd: file descriptor to listen on
* @event: bitset of events on which to fire the callback
- * @cb: the callback to be called when an event occurrs
+ * @cb: the callback to be called when an event occurs
* @opaque: user data to pass to the callback
* @ff: the callback invoked to free opaque data blob
*
diff --git a/src/access/viraccessperm.h b/src/access/viraccessperm.h
index 5ac5ff3377..10ce2dc139 100644
--- a/src/access/viraccessperm.h
+++ b/src/access/viraccessperm.h
@@ -417,7 +417,7 @@ typedef enum {
/**
* @desc: Access node device
- * @message: Accesing node device requires authorization
+ * @message: Accessing node device requires authorization
* @anonymous: 1
*/
VIR_ACCESS_PERM_NODE_DEVICE_GETATTR,
@@ -637,7 +637,7 @@ typedef enum {
/**
* @desc: Access storage volume
- * @message: Acceessing storage
Re: [libvirt] [PATCH] Fix minor typos in messages
On 29.04.2016 20:22, Yuri Chornoivan wrote: > Hi, > > Many thanks for reviewing this patch. > > Best regards, > Yuri Usually, we use 'git send-email' because it sends a patch directly, not as an attachment. But I've applied it anyway. ACKed and pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix minor typos in messages
Hi, Many thanks for reviewing this patch. Best regards, Yuri 0001-Fix-minor-typos-in-messages.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix minor typos in messages
On Mon, 2016-03-07 at 15:32 +0200, Yuri Chornoivan wrote: > Hi, > > Attached is a patch to fix minor typos in libvirt messages. Thanks for > fixing them in the repo. Pushed, thanks for your contribution :) > By the way, libvirt template has not been updated for almost 1 year on > Zanata. Are the translation moved into some new location? Unfortunately I don't have the answer to this question, but I'm sure someone else on the list will be able to explain what's going on... Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix minor typos in messages
Hi, Attached is a patch to fix minor typos in libvirt messages. Thanks for fixing them in the repo. By the way, libvirt template has not been updated for almost 1 year on Zanata. Are the translation moved into some new location? Thanks in advance for your answers. Best regards, Yuri 0001-Fix-minor-typos.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix minor typos in messages and docs
On 07/30/2013 02:24 AM, Yuri Chornoivan wrote: > > 0001-Fix-minor-typos-in-messages-and-docs.patch > > >>From 1b8af1b915f3cce1d27576f651e99b6ce3a73e3a Mon Sep 17 00:00:00 2001 > From: Yuri Chornoivan > Date: Tue, 30 Jul 2013 11:21:11 +0300 > Subject: [PATCH] Fix minor typos in messages and docs > > --- > docs/apibuild.py | 2 +- > docs/formatdomain.html.in | 6 ++--- > docs/hacking.html.in | 2 +- > docs/migration.html.in| 4 ++-- > docs/news.html.in | 60 > +++ > src/esx/esx_vi.c | 2 +- > src/lxc/lxc_driver.c | 4 ++-- > 7 files changed, 40 insertions(+), 40 deletions(-) > ACK and pushed. (Too bad this missed the release; some of the typos are in error messages now baked into .po files.) > +++ b/docs/news.html.in > @@ -460,7 +460,7 @@ and check the href="http://libvirt.org/git/?p=libvirt.git;a=log";>GIT log >Add libvirt-daemon-vbox & libvirt-daemon-driver-vbox RPMs (Daniel > P. Berrange), >Include GNULIB mkdtemp module (Daniel P. Berrange), >Set PKG_CONFIG_LIBDIR in autobuild.sh (Daniel P. Berrange), > - qemu: report useful error failling to destroy domain gracefully > (Guannan Ren), > + qemu: report useful error failing to destroy domain gracefully > (Guannan Ren), These typos are extracted from 'git short-log' history; I'm hoping that they don't get reinstated when DV does releases. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix minor typos in messages and docs
>From 1b8af1b915f3cce1d27576f651e99b6ce3a73e3a Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Tue, 30 Jul 2013 11:21:11 +0300 Subject: [PATCH] Fix minor typos in messages and docs --- docs/apibuild.py | 2 +- docs/formatdomain.html.in | 6 ++--- docs/hacking.html.in | 2 +- docs/migration.html.in| 4 ++-- docs/news.html.in | 60 +++ src/esx/esx_vi.c | 2 +- src/lxc/lxc_driver.c | 4 ++-- 7 files changed, 40 insertions(+), 40 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index e65c559..5c55d79 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -919,7 +919,7 @@ class CParser: l = lines[0] i = 0 # Remove all leading '*', followed by at most one ' ' character -# since we need to preserve correct identation of code examples +# since we need to preserve correct indentation of code examples while i < len(l) and l[i] == '*': i = i + 1 if i > 0: diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 78e132e..49c7c8d 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1001,7 +1001,7 @@ - Guest NUMA topology can be specifed using the numa element. + Guest NUMA topology can be specified using the numa element. Since 0.9.8 @@ -3034,7 +3034,7 @@ Provides direct attachment of the virtual machine's NIC to the given - physial interface of the host. + physical interface of the host. Since 0.7.7 (QEMU and KVM only) This setup requires the Linux macvtap driver to be available. (Since Linux 2.6.34.) @@ -3439,7 +3439,7 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This - name can be manually specifed, however the name must not + name can be manually specified, however the name must not start with either 'vnet' or 'vif', which are prefixes reserved by libvirt and certain hypervisors. Manually specified targets using these prefixes will be ignored. diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 700eb3a..8120b19 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -207,7 +207,7 @@ ==4643==by 0x34D8C01569: ??? (in /usr/lib64/ld-2.15.so) -In this instance, it is acceptible to modify the +In this instance, it is acceptable to modify the tests/.valgrind.supp file in order to add a suppression filter. The filter should be unique enough to not suppress real leaks, but it should be generic enough to diff --git a/docs/migration.html.in b/docs/migration.html.in index 2ea0969..6986cc0 100644 --- a/docs/migration.html.in +++ b/docs/migration.html.in @@ -9,7 +9,7 @@ Migration of guests between hosts is a complicated problem with many possible solutions, each with their own positive and negative points. For maximum - flexibility of both hypervisor integration, and adminsitrator deployment, + flexibility of both hypervisor integration, and administrator deployment, libvirt implements several options for migration. @@ -187,7 +187,7 @@ URI. In this case the management application should specify the hypervisor specific URI explicitly, using an IP address, or a correct hostname. - The host has multiple network interaces. If a host has multiple + The host has multiple network interfaces. If a host has multiple network interfaces, it might be desirable for the migration data stream to be sent over a specific interface for either security or performance reasons. In this case the management application diff --git a/docs/news.html.in b/docs/news.html.in index 059b2bc..f176d30 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -460,7 +460,7 @@ and check the http://libvirt.org/git/?p=libvirt.git;a=log";>GIT log Add libvirt-daemon-vbox & libvirt-daemon-driver-vbox RPMs (Daniel P. Berrange), Include GNULIB mkdtemp module (Daniel P. Berrange), Set PKG_CONFIG_LIBDIR in autobuild.sh (Daniel P. Berrange), - qemu: report useful error failling to destroy domain gracefully (Guannan Ren), + qemu: report useful error failing to destroy domain gracefully (Guannan Ren), qemu: Check conflicts for shared scsi host device (Osier Yang), Re-add selinux/selinux.h to lxc_container.c (Daniel P. Berrange), schema: make source optional in volume XML (Ján Tomko), @@ -1222,7 +1222,7 @@ and check the http://libvirt.org/git/?p=libvirt.git;a=log";>GIT log S390: Documentation for CCW address type (Viktor Mihajlovski), Use separate symbol file for GNUTLS symbols (Daniel P. Berrange), Apply security label when enteri
