[libvirt] [PATCH] Fix underlinking of libvirt_driver_interface.so

2015-03-23 Thread Natanael Copa 
Always add udev linker flags when WITH_UDEV is enabled to avoid
underlinking.

See commit 43dbcb15 (interface: always build all available backends)

Signed-off-by: Natanael Copa nc...@alpinelinux.org
---
 src/Makefile.am | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 956d9ce..00b47e7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1457,12 +1457,11 @@ libvirt_driver_interface_la_LIBADD =
 if WITH_NETCF
 libvirt_driver_interface_la_CFLAGS += $(NETCF_CFLAGS)
 libvirt_driver_interface_la_LIBADD += $(NETCF_LIBS)
-else ! WITH_NETCF
+endif WITH_NETCF
 if WITH_UDEV
 libvirt_driver_interface_la_CFLAGS += $(UDEV_CFLAGS)
 libvirt_driver_interface_la_LIBADD += $(UDEV_LIBS)
 endif WITH_UDEV
-endif ! WITH_NETCF
 if WITH_DRIVER_MODULES
 libvirt_driver_interface_la_LIBADD += ../gnulib/lib/libgnu.la
 libvirt_driver_interface_la_LDFLAGS += -module -avoid-version
-- 
2.3.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix underlinking of libvirt_driver_interface.so

2015-03-23 Thread Ján Tomko 
On Mon, Mar 23, 2015 at 10:11:14AM +0100, Natanael Copa wrote:
 Always add udev linker flags when WITH_UDEV is enabled to avoid
 underlinking.
 
 See commit 43dbcb15 (interface: always build all available backends)
 
 Signed-off-by: Natanael Copa nc...@alpinelinux.org
 ---
  src/Makefile.am | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
 

ACK and pushed.

Jan

 diff --git a/src/Makefile.am b/src/Makefile.am
 index 956d9ce..00b47e7 100644
 --- a/src/Makefile.am
 +++ b/src/Makefile.am
 @@ -1457,12 +1457,11 @@ libvirt_driver_interface_la_LIBADD =
  if WITH_NETCF
  libvirt_driver_interface_la_CFLAGS += $(NETCF_CFLAGS)
  libvirt_driver_interface_la_LIBADD += $(NETCF_LIBS)
 -else ! WITH_NETCF
 +endif WITH_NETCF
  if WITH_UDEV
  libvirt_driver_interface_la_CFLAGS += $(UDEV_CFLAGS)
  libvirt_driver_interface_la_LIBADD += $(UDEV_LIBS)
  endif WITH_UDEV
 -endif ! WITH_NETCF
  if WITH_DRIVER_MODULES
  libvirt_driver_interface_la_LIBADD += ../gnulib/lib/libgnu.la
  libvirt_driver_interface_la_LDFLAGS += -module -avoid-version
 -- 
 2.3.3
 
 --
 libvir-list mailing list
 libvir-list@redhat.com
 https://www.redhat.com/mailman/listinfo/libvir-list


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list