Re: [libvirt] [PATCH] LXC: show used memory as 0 when domain is not active

2014-07-23 Thread Gao feng 
On 07/17/2014 05:28 PM, Chen Hanxiao wrote:
 Before:
 virsh # dominfo chx3
 State:  shut off
 Max memory: 92160 KiB
 Used memory:92160 KiB
 
 After:
 virsh # dominfo container1
 State:  shut off
 Max memory: 92160 KiB
 Used memory:0 KiB
 
 Similar to qemu cases.
 
 Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
 ---
  src/lxc/lxc_driver.c   | 2 +-
  src/qemu/qemu_driver.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
 


ACK  Pushed, thanks!

 diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
 index b7b4b02..f094f86 100644
 --- a/src/lxc/lxc_driver.c
 +++ b/src/lxc/lxc_driver.c
 @@ -584,7 +584,7 @@ static int lxcDomainGetInfo(virDomainPtr dom,
  
  if (!virDomainObjIsActive(vm)) {
  info-cpuTime = 0;
 -info-memory = vm-def-mem.cur_balloon;
 +info-memory = 0;
  } else {
  if (virCgroupGetCpuacctUsage(priv-cgroup, (info-cpuTime))  0) {
  virReportError(VIR_ERR_OPERATION_FAILED,
 diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
 index 33541d3..01107cf 100644
 --- a/src/qemu/qemu_driver.c
 +++ b/src/qemu/qemu_driver.c
 @@ -2534,7 +2534,7 @@ static int qemuDomainGetInfo(virDomainPtr dom,
  info-memory = vm-def-mem.cur_balloon;
  }
  } else {
 -info-memory = vm-def-mem.cur_balloon;
 +info-memory = 0;
  }
  
  info-nrVirtCpu = vm-def-vcpus;
 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] LXC: show used memory as 0 when domain is not active

2014-07-21 Thread chenhanx...@cn.fujitsu.com 
ping

 -Original Message-
 From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
 On Behalf Of Chen Hanxiao
 Sent: Thursday, July 17, 2014 5:28 PM
 To: libvir-list@redhat.com
 Subject: [libvirt] [PATCH] LXC: show used memory as 0 when domain is not 
 active
 
 Before:
 virsh # dominfo chx3
 State:  shut off
 Max memory: 92160 KiB
 Used memory:92160 KiB
 
 After:
 virsh # dominfo container1
 State:  shut off
 Max memory: 92160 KiB
 Used memory:0 KiB
 
 Similar to qemu cases.
 
 Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
 ---
  src/lxc/lxc_driver.c   | 2 +-
  src/qemu/qemu_driver.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
 index b7b4b02..f094f86 100644
 --- a/src/lxc/lxc_driver.c
 +++ b/src/lxc/lxc_driver.c
 @@ -584,7 +584,7 @@ static int lxcDomainGetInfo(virDomainPtr dom,
 
  if (!virDomainObjIsActive(vm)) {
  info-cpuTime = 0;
 -info-memory = vm-def-mem.cur_balloon;
 +info-memory = 0;
  } else {
  if (virCgroupGetCpuacctUsage(priv-cgroup, (info-cpuTime))  0) {
  virReportError(VIR_ERR_OPERATION_FAILED,
 diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
 index 33541d3..01107cf 100644
 --- a/src/qemu/qemu_driver.c
 +++ b/src/qemu/qemu_driver.c
 @@ -2534,7 +2534,7 @@ static int qemuDomainGetInfo(virDomainPtr dom,
  info-memory = vm-def-mem.cur_balloon;
  }
  } else {
 -info-memory = vm-def-mem.cur_balloon;
 +info-memory = 0;
  }
 
  info-nrVirtCpu = vm-def-vcpus;
 --
 1.9.0
 
 --
 libvir-list mailing list
 libvir-list@redhat.com
 https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] LXC: show used memory as 0 when domain is not active

2014-07-17 Thread Chen Hanxiao 
Before:
virsh # dominfo chx3
State:  shut off
Max memory: 92160 KiB
Used memory:92160 KiB

After:
virsh # dominfo container1
State:  shut off
Max memory: 92160 KiB
Used memory:0 KiB

Similar to qemu cases.

Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
 src/lxc/lxc_driver.c   | 2 +-
 src/qemu/qemu_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index b7b4b02..f094f86 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -584,7 +584,7 @@ static int lxcDomainGetInfo(virDomainPtr dom,
 
 if (!virDomainObjIsActive(vm)) {
 info-cpuTime = 0;
-info-memory = vm-def-mem.cur_balloon;
+info-memory = 0;
 } else {
 if (virCgroupGetCpuacctUsage(priv-cgroup, (info-cpuTime))  0) {
 virReportError(VIR_ERR_OPERATION_FAILED,
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 33541d3..01107cf 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2534,7 +2534,7 @@ static int qemuDomainGetInfo(virDomainPtr dom,
 info-memory = vm-def-mem.cur_balloon;
 }
 } else {
-info-memory = vm-def-mem.cur_balloon;
+info-memory = 0;
 }
 
 info-nrVirtCpu = vm-def-vcpus;
-- 
1.9.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list