Re: [libvirt] [PATCH] Makefile.nonreentrant: Rebuild against Fedora 26

2017-09-04 Thread Daniel P. Berrange 
On Mon, Sep 04, 2017 at 03:06:16PM +0200, Andrea Bolognani wrote:
> According to the comments in the file and the git history, the
> list of forbidden symbols was originally built against Fedora 9
> in 2009 (!) and pretty much never refreshed afterwards.
> 
> Signed-off-by: Andrea Bolognani 
> ---
> I didn't put too much thought into this, but the results looks
> sane enough as we are only *adding* to the list.
> 
>  Makefile.nonreentrant | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrange 

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Makefile.nonreentrant: Rebuild against Fedora 26

2017-09-04 Thread Andrea Bolognani 
According to the comments in the file and the git history, the
list of forbidden symbols was originally built against Fedora 9
in 2009 (!) and pretty much never refreshed afterwards.

Signed-off-by: Andrea Bolognani 
---
I didn't put too much thought into this, but the results looks
sane enough as we are only *adding* to the list.

 Makefile.nonreentrant | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Makefile.nonreentrant b/Makefile.nonreentrant
index 5cc64c0d5..a83298322 100644
--- a/Makefile.nonreentrant
+++ b/Makefile.nonreentrant
@@ -15,9 +15,9 @@
 ## .
 
 #
-# Generated by running the following on Fedora 9:
+# Generated by running the following on Fedora 26:
 #
-#  nm -D --defined-only /lib/libc.so.6  \
+#  nm -D --defined-only /lib64/libc.so.6  \
 #  | grep '_r$' \
 #  | awk '{print $3}' \
 #  | grep -v __ \
@@ -43,6 +43,7 @@ NON_REENTRANT += ether_ntoa
 NON_REENTRANT += fcvt
 NON_REENTRANT += fgetgrent
 NON_REENTRANT += fgetpwent
+NON_REENTRANT += fgetsgent
 NON_REENTRANT += fgetspent
 NON_REENTRANT += getaliasbyname
 NON_REENTRANT += getaliasent
@@ -72,6 +73,8 @@ NON_REENTRANT += getrpcent
 NON_REENTRANT += getservbyname
 NON_REENTRANT += getservbyport
 NON_REENTRANT += getservent
+NON_REENTRANT += getsgent
+NON_REENTRANT += getsgnam
 NON_REENTRANT += getspent
 NON_REENTRANT += getspnam
 NON_REENTRANT += getutent
@@ -95,6 +98,7 @@ NON_REENTRANT += random
 NON_REENTRANT += rand
 NON_REENTRANT += seed48
 NON_REENTRANT += setstate
+NON_REENTRANT += sgetsgent
 NON_REENTRANT += sgetspent
 NON_REENTRANT += srand48
 NON_REENTRANT += srandom
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list