Re: [libvirt] [PATCH] build: speed up non-maintainer builds

2011-02-18 Thread Eric Blake
On 02/13/2011 09:29 PM, Daniel Veillard wrote:
 On Fri, Feb 11, 2011 at 12:45:36PM -0700, Eric Blake wrote:
 * configure.ac (gl_ASSERT_NO_GNULIB_POSIXCHECK): Use to reduce
 time spent in configure.
 ---

 This skips out on the bulk of the 'declared without a macro' checks
 during configure time (they are only useful if you are going to
 run with CFLAGS=-DGNULIB_POSIXCHECK=1, but that's a maintainer action);
 it also results in a smaller config.h (no HAVE_RAW_DECL substitutions).

 Worth including in 0.8.8?
 
   Hum, that's an improvement and I'm a bit vary of the build side effect,
 I would feel a bit safer if we just waited a bit to push this after the
 release, okay ?

It's now after the release, so taking this as an ACK, I've pushed it.

-- 
Eric Blake   ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] build: speed up non-maintainer builds

2011-02-13 Thread Daniel Veillard
On Fri, Feb 11, 2011 at 12:45:36PM -0700, Eric Blake wrote:
 * configure.ac (gl_ASSERT_NO_GNULIB_POSIXCHECK): Use to reduce
 time spent in configure.
 ---
 
 This skips out on the bulk of the 'declared without a macro' checks
 during configure time (they are only useful if you are going to
 run with CFLAGS=-DGNULIB_POSIXCHECK=1, but that's a maintainer action);
 it also results in a smaller config.h (no HAVE_RAW_DECL substitutions).
 
 Worth including in 0.8.8?

  Hum, that's an improvement and I'm a bit vary of the build side effect,
I would feel a bit safer if we just waited a bit to push this after the
release, okay ?

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list