Re: [libvirt] [PATCH] libvirt: Update docs for hotplug only commands

2010-02-18 Thread Cole Robinson
On 02/18/2010 07:45 AM, Daniel P. Berrange wrote:
> On Tue, Feb 16, 2010 at 02:35:49PM -0500, Cole Robinson wrote:
>> The commands updated are SetMem, SetMaxMem, SetVcpus, and PinVcpu.
>>
>> Signed-off-by: Cole Robinson 
>> ---
>>  src/libvirt.c |   12 
>>  1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/libvirt.c b/src/libvirt.c
>> index 0e5f4a2..be17668 100644
>> --- a/src/libvirt.c
>> +++ b/src/libvirt.c
>> @@ -2758,6 +2758,9 @@ error:
>>   * to Domain0 i.e. the domain where the application runs.
>>   * This function requires privileged access to the hypervisor.
>>   *
>> + * This command only changes the runtime configuration of the domain,
>> + * so can only be called on an active domain.
>> + *
>>   * Returns 0 in case of success and -1 in case of failure.
>>   */
>>  int
>> @@ -2808,6 +2811,9 @@ error:
>>   * to Domain0 i.e. the domain where the application runs.
>>   * This function may requires privileged access to the hypervisor.
>>   *
>> + * This command only changes the runtime configuration of the domain,
>> + * so can only be called on an active domain.
>> + *
>>   * Returns 0 in case of success and -1 in case of failure.
>>   */
>>  int
>> @@ -4821,6 +4827,9 @@ error:
>>   * does not support it or if growing the number is arbitrary limited.
>>   * This function requires privileged access to the hypervisor.
>>   *
>> + * This command only changes the runtime configuration of the domain,
>> + * so can only be called on an active domain.
>> + *
>>   * Returns 0 in case of success, -1 in case of failure.
>>   */
>>  
>> @@ -4879,6 +4888,9 @@ error:
>>   * Dynamically change the real CPUs which can be allocated to a virtual CPU.
>>   * This function requires privileged access to the hypervisor.
>>   *
>> + * This command only changes the runtime configuration of the domain,
>> + * so can only be called on an active domain.
>> + *
>>   * Returns 0 in case of success, -1 in case of failure.
>>   */
>>  int
>> --
> 
> ACK
> 
> 
> Daniel

Thanks, pushed now.

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH] libvirt: Update docs for hotplug only commands

2010-02-18 Thread Daniel P. Berrange
On Tue, Feb 16, 2010 at 02:35:49PM -0500, Cole Robinson wrote:
> The commands updated are SetMem, SetMaxMem, SetVcpus, and PinVcpu.
> 
> Signed-off-by: Cole Robinson 
> ---
>  src/libvirt.c |   12 
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 0e5f4a2..be17668 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -2758,6 +2758,9 @@ error:
>   * to Domain0 i.e. the domain where the application runs.
>   * This function requires privileged access to the hypervisor.
>   *
> + * This command only changes the runtime configuration of the domain,
> + * so can only be called on an active domain.
> + *
>   * Returns 0 in case of success and -1 in case of failure.
>   */
>  int
> @@ -2808,6 +2811,9 @@ error:
>   * to Domain0 i.e. the domain where the application runs.
>   * This function may requires privileged access to the hypervisor.
>   *
> + * This command only changes the runtime configuration of the domain,
> + * so can only be called on an active domain.
> + *
>   * Returns 0 in case of success and -1 in case of failure.
>   */
>  int
> @@ -4821,6 +4827,9 @@ error:
>   * does not support it or if growing the number is arbitrary limited.
>   * This function requires privileged access to the hypervisor.
>   *
> + * This command only changes the runtime configuration of the domain,
> + * so can only be called on an active domain.
> + *
>   * Returns 0 in case of success, -1 in case of failure.
>   */
>  
> @@ -4879,6 +4888,9 @@ error:
>   * Dynamically change the real CPUs which can be allocated to a virtual CPU.
>   * This function requires privileged access to the hypervisor.
>   *
> + * This command only changes the runtime configuration of the domain,
> + * so can only be called on an active domain.
> + *
>   * Returns 0 in case of success, -1 in case of failure.
>   */
>  int
> --

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH] libvirt: Update docs for hotplug only commands

2010-02-16 Thread Cole Robinson
The commands updated are SetMem, SetMaxMem, SetVcpus, and PinVcpu.

Signed-off-by: Cole Robinson 
---
 src/libvirt.c |   12 
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/src/libvirt.c b/src/libvirt.c
index 0e5f4a2..be17668 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -2758,6 +2758,9 @@ error:
  * to Domain0 i.e. the domain where the application runs.
  * This function requires privileged access to the hypervisor.
  *
+ * This command only changes the runtime configuration of the domain,
+ * so can only be called on an active domain.
+ *
  * Returns 0 in case of success and -1 in case of failure.
  */
 int
@@ -2808,6 +2811,9 @@ error:
  * to Domain0 i.e. the domain where the application runs.
  * This function may requires privileged access to the hypervisor.
  *
+ * This command only changes the runtime configuration of the domain,
+ * so can only be called on an active domain.
+ *
  * Returns 0 in case of success and -1 in case of failure.
  */
 int
@@ -4821,6 +4827,9 @@ error:
  * does not support it or if growing the number is arbitrary limited.
  * This function requires privileged access to the hypervisor.
  *
+ * This command only changes the runtime configuration of the domain,
+ * so can only be called on an active domain.
+ *
  * Returns 0 in case of success, -1 in case of failure.
  */
 
@@ -4879,6 +4888,9 @@ error:
  * Dynamically change the real CPUs which can be allocated to a virtual CPU.
  * This function requires privileged access to the hypervisor.
  *
+ * This command only changes the runtime configuration of the domain,
+ * so can only be called on an active domain.
+ *
  * Returns 0 in case of success, -1 in case of failure.
  */
 int
-- 
1.6.5.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list