Re: [libvirt] [PATCH] m4: bhyve: Fix check for the required bhyve programs
On 06/06/14 17:58, Eric Blake wrote: > On 06/06/2014 09:27 AM, Peter Krempa wrote: >> bhyveload and bhyvectl wouldn't be checked otherwise as the configure >> script wouldn't execute one of the tests: >> >> checking for bhyve... /usr/local/sbin/bhyve >> checking for bhyvectl... /usr/local/sbin/bhyvectl >> checking for bhyveload... /usr/local/sbin/bhyveload >> ./configure: line 62602: test: too many arguments >> >> Fix the shell statement testing the 3 binaries. >> --- >> m4/virt-driver-bhyve.m4 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > ACK. > Pushed; Thanks. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] m4: bhyve: Fix check for the required bhyve programs
On 06/06/2014 09:27 AM, Peter Krempa wrote: > bhyveload and bhyvectl wouldn't be checked otherwise as the configure > script wouldn't execute one of the tests: > > checking for bhyve... /usr/local/sbin/bhyve > checking for bhyvectl... /usr/local/sbin/bhyvectl > checking for bhyveload... /usr/local/sbin/bhyveload > ./configure: line 62602: test: too many arguments > > Fix the shell statement testing the 3 binaries. > --- > m4/virt-driver-bhyve.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] m4: bhyve: Fix check for the required bhyve programs
bhyveload and bhyvectl wouldn't be checked otherwise as the configure script wouldn't execute one of the tests: checking for bhyve... /usr/local/sbin/bhyve checking for bhyvectl... /usr/local/sbin/bhyvectl checking for bhyveload... /usr/local/sbin/bhyveload ./configure: line 62602: test: too many arguments Fix the shell statement testing the 3 binaries. --- m4/virt-driver-bhyve.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-driver-bhyve.m4 b/m4/virt-driver-bhyve.m4 index 9c0030b..c65b15d 100644 --- a/m4/virt-driver-bhyve.m4 +++ b/m4/virt-driver-bhyve.m4 @@ -28,7 +28,7 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_BHYVE],[ AC_PATH_PROG([BHYVECTL], [bhyvectl], [], [$PATH:/usr/sbin]) AC_PATH_PROG([BHYVELOAD], [bhyveload], [], [$PATH:/usr/sbin/]) -if test -z "$BHYVE" || test -z "$BHYVECTL" \ +if test -z "$BHYVE" || test -z "$BHYVECTL" || \ test -z "$BHYVELOAD" || test "$with_freebsd" = "no"; then if test "$with_bhyve" = "check"; then with_bhyve="no" -- 1.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
