[libvirt] [PATCH] nodedev: fix a uninitialized variable build failure

2014-07-28 Thread Chen Hanxiao 
Fix a -Werror=maybe-uninitialized warring

Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
 src/conf/node_device_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 78bc63f..96524a6 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -1349,7 +1349,7 @@ virNodeDevCapsDefParseXML(xmlXPathContextPtr ctxt,
 {
 virNodeDevCapsDefPtr caps;
 char *tmp;
-int val, ret;
+int val, ret = -1;
 
 if (VIR_ALLOC(caps)  0)
 return NULL;
-- 
1.9.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] nodedev: fix a uninitialized variable build failure

2014-07-28 Thread Eric Blake 
On 07/28/2014 08:05 PM, Chen Hanxiao wrote:
 Fix a -Werror=maybe-uninitialized warring

s/warring/warning/

Uninitialized only if caps-type is out-of-bounds from its enum type.
ACK and pushed.

 
 Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
 ---
  src/conf/node_device_conf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
 index 78bc63f..96524a6 100644
 --- a/src/conf/node_device_conf.c
 +++ b/src/conf/node_device_conf.c
 @@ -1349,7 +1349,7 @@ virNodeDevCapsDefParseXML(xmlXPathContextPtr ctxt,
  {
  virNodeDevCapsDefPtr caps;
  char *tmp;
 -int val, ret;
 +int val, ret = -1;
  
  if (VIR_ALLOC(caps)  0)
  return NULL;
 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list