Re: [libvirt] [PATCH] qemu: Don't update graphic definitions on password change failure

2012-09-04 Thread Michal Privoznik 
On 03.09.2012 17:07, Peter Krempa wrote:
 When the password change failed we updated the graphic definition
 anyways, which is not desired.
 ---
  src/qemu/qemu_hotplug.c | 5 +
  1 file changed, 5 insertions(+)
 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Don't update graphic definitions on password change failure

2012-09-04 Thread Peter Krempa 

On 09/04/12 09:03, Michal Privoznik wrote:

On 03.09.2012 17:07, Peter Krempa wrote:

When the password change failed we updated the graphic definition
anyways, which is not desired.
---
  src/qemu/qemu_hotplug.c | 5 +
  1 file changed, 5 insertions(+)



ACK



Pushed. Thanks!

Peter

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Don't update graphic definitions on password change failure

2012-09-03 Thread Peter Krempa 
When the password change failed we updated the graphic definition
anyways, which is not desired.
---
 src/qemu/qemu_hotplug.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 1251d6b..a8a904c 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1517,6 +1517,8 @@ qemuDomainChangeGraphics(struct qemud_driver *driver,
 
VIR_DOMAIN_GRAPHICS_TYPE_VNC,
 dev-data.vnc.auth,
 driver-vncPassword);
+if (ret  0)
+return ret;

 /* Steal the new dev's  char * reference */
 VIR_FREE(olddev-data.vnc.auth.passwd);
@@ -1576,6 +1578,9 @@ qemuDomainChangeGraphics(struct qemud_driver *driver,
 dev-data.spice.auth,
 driver-spicePassword);

+if (ret  0)
+return ret;
+
 /* Steal the new dev's char * reference */
 VIR_FREE(olddev-data.spice.auth.passwd);
 olddev-data.spice.auth.passwd = dev-data.spice.auth.passwd;
-- 
1.7.12

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list