Re: [libvirt] [PATCH] qemu: parse -device virtio-balloon
Ping? The meat of this is very small - most of the lines are just changes to test data. On 06/09/2014 01:29 PM, Laine Stump wrote: There are no options to parse here, and all three possible device names have the same prefix (virtio-balloon with -ccw, -pci, or -device appended), so it is fairly simple. qemuParseCommandLineString() previously would always add a memballoon model='virtio'/ to every result (the comments erroneously say that it is adding a memballoon model='none'/) This has been changed to add model='none', and 84 test case xml's updated accordingly (so that qemuxml2argvtest won't fail). Now that the memballoon device is properly parsed, we can safely add a test for properly ignoring -nodefconfig and -nodefaults. Rather than adding an entire new test case for this (and memballoon), we just randomly pick the clock-utc test and modify it slightly to fulfill the purpose. --- I don't necessarily have any love for the memory balloon driver, but this ended up being necessary in order to prevent test failures after fixing the patch here to not ignore unrecognized -device args: https://www.redhat.com/archives/libvir-list/2014-June/msg00388.html src/qemu/qemu_command.c | 8 +++- tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args| 7 --- tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml| 2 +- .../qemuxml2argv-disk-drive-error-policy-enospace.xml | 2 +- .../qemuxml2argv-disk-drive-error-policy-stop.xml | 2 +- .../qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi.xml | 2 +- .../qemuxml2argv-disk-drive-network-nbd-export.xml| 2 +- .../qemuxml2argv-disk-drive-network-nbd-ipv6-export.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-unix.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml| 2 +- .../qemuxml2argv-disk-drive-network-rbd-ceph-env.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ipv6.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml| 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-websocket.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml| 2 +-
Re: [libvirt] [PATCH] qemu: parse -device virtio-balloon
On 06/09/2014 04:29 AM, Laine Stump wrote: There are no options to parse here, and all three possible device names have the same prefix (virtio-balloon with -ccw, -pci, or -device appended), so it is fairly simple. qemuParseCommandLineString() previously would always add a memballoon model='virtio'/ to every result (the comments erroneously say that it is adding a memballoon model='none'/) This has been changed to add model='none', and 84 test case xml's updated accordingly (so that qemuxml2argvtest won't fail). Now that the memballoon device is properly parsed, we can safely add a test for properly ignoring -nodefconfig and -nodefaults. Rather than adding an entire new test case for this (and memballoon), we just randomly pick the clock-utc test and modify it slightly to fulfill the purpose. Wise decision - it's already big enough tweaking everything :) --- I don't necessarily have any love for the memory balloon driver, but this ended up being necessary in order to prevent test failures after fixing the patch here to not ignore unrecognized -device args: https://www.redhat.com/archives/libvir-list/2014-June/msg00388.html ACK. Big patch, but only 2 or 3 files contain any real changes, and all the rest is mechanical fallout. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] qemu: parse -device virtio-balloon
There are no options to parse here, and all three possible device names have the same prefix (virtio-balloon with -ccw, -pci, or -device appended), so it is fairly simple. qemuParseCommandLineString() previously would always add a memballoon model='virtio'/ to every result (the comments erroneously say that it is adding a memballoon model='none'/) This has been changed to add model='none', and 84 test case xml's updated accordingly (so that qemuxml2argvtest won't fail). Now that the memballoon device is properly parsed, we can safely add a test for properly ignoring -nodefconfig and -nodefaults. Rather than adding an entire new test case for this (and memballoon), we just randomly pick the clock-utc test and modify it slightly to fulfill the purpose. --- I don't necessarily have any love for the memory balloon driver, but this ended up being necessary in order to prevent test failures after fixing the patch here to not ignore unrecognized -device args: https://www.redhat.com/archives/libvir-list/2014-June/msg00388.html src/qemu/qemu_command.c | 8 +++- tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args| 7 --- tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-cache-directsync.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-unsafe.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml| 2 +- .../qemuxml2argv-disk-drive-error-policy-enospace.xml | 2 +- .../qemuxml2argv-disk-drive-error-policy-stop.xml | 2 +- .../qemuxml2argv-disk-drive-error-policy-wreport-rignore.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-gluster.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi.xml | 2 +- .../qemuxml2argv-disk-drive-network-nbd-export.xml| 2 +- .../qemuxml2argv-disk-drive-network-nbd-ipv6-export.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-unix.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml| 2 +- .../qemuxml2argv-disk-drive-network-rbd-ceph-env.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-ipv6.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml| 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-policy.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-websocket.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml| 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml | 2 +- tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml | 2 +-
