Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

[Daniel P. Berrange]

On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido G?nther wrote:
 Hi,
 open returns -1 on failure. Pointed out by Guido Trotter on:

Opps, very embarrassing bug :-) ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

[Daniel Veillard]

On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido Günther wrote:
 Hi,
 open returns -1 on failure. Pointed out by Guido Trotter on:
 
 http://bugs.debian.org/492250
 
 Patch against current CVS attached.

  Hum, good catch, I checked for other occurences of this mistake but
everywhere else we use  0 or == -1 to detect the failure.

  Applied and commited,

   thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard  | virtualization library  http://libvirt.org/
[EMAIL PROTECTED]  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

[Guido Günther]

Hi,
open returns -1 on failure. Pointed out by Guido Trotter on:

http://bugs.debian.org/492250

Patch against current CVS attached.
 -- Guido
 
---
 src/qemu_driver.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 8015b63..2539d78 100644
--- a/src/qemu_driver.c
+++ b/src/qemu_driver.c
@@ -505,7 +505,7 @@ static int qemudOpenMonitor(virConnectPtr conn,
 char buf[1024];
 int ret = -1;
 
-if (!(monfd = open(monitor, O_RDWR))) {
+if ((monfd = open(monitor, O_RDWR))  0) {
 qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
  _(Unable to open monitor path %s), monitor);
 return -1;
-- 
1.5.6.3

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list