Re: [libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27
On Fri, Aug 4, 2017 at 11:20 AM, Daniel P. Berrange wrote: > On Fri, Aug 04, 2017 at 04:37:37PM +0200, Michal Privoznik wrote: >> On 08/02/2017 11:52 AM, Daniel P. Berrange wrote: >> > Signed-off-by: Daniel P. Berrange >> > --- >> > libvirt.spec.in | 4 >> > mingw-libvirt.spec.in | 4 >> > 2 files changed, 8 insertions(+) >> > >> > diff --git a/libvirt.spec.in b/libvirt.spec.in >> > index b074bd171..8abecae22 100644 >> > --- a/libvirt.spec.in >> > +++ b/libvirt.spec.in >> > @@ -292,7 +292,11 @@ BuildRequires: libtool >> > BuildRequires: /usr/bin/pod2man >> > %endif >> > BuildRequires: git >> > +%if 0%{?fedora} >= 27 >> > +BuildRequires: perl-interpretor >> >> s/interpretor/interpreter/ > > Sigh, I guess this time i *should* have cut+paste ;-) > >> >> > +%else >> > BuildRequires: perl >> > +%endif >> > BuildRequires: python >> > %if %{with_systemd} >> > BuildRequires: systemd-units >> > diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in >> > index 4efa0ddbf..553d14022 100644 >> > --- a/mingw-libvirt.spec.in >> > +++ b/mingw-libvirt.spec.in >> > @@ -59,7 +59,11 @@ BuildRequires: pkgconfig >> > # Need native version for msgfmt >> > BuildRequires: gettext >> > BuildRequires: python >> > +%if 0%{?fedora} >= 27 >> > +BuildRequires: perl-interpretor >> >> again. >> >> > +%else >> > BuildRequires: perl >> > +%endif >> > BuildRequires: perl(Getopt::Long) >> > %if 0%{?enable_autotools} >> > BuildRequires: autoconf >> > >> >> ACK with that fixed. >> Why are you doing this F27 specific? The perl-interpreter Provides was added to all supported Fedora releases, so you could have just made it a 0%{?fedora} thing rather than specifically F27. -- 真実はいつも一つ!/ Always, there's only one truth! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27
On Fri, Aug 04, 2017 at 04:37:37PM +0200, Michal Privoznik wrote: > On 08/02/2017 11:52 AM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > libvirt.spec.in | 4 > > mingw-libvirt.spec.in | 4 > > 2 files changed, 8 insertions(+) > > > > diff --git a/libvirt.spec.in b/libvirt.spec.in > > index b074bd171..8abecae22 100644 > > --- a/libvirt.spec.in > > +++ b/libvirt.spec.in > > @@ -292,7 +292,11 @@ BuildRequires: libtool > > BuildRequires: /usr/bin/pod2man > > %endif > > BuildRequires: git > > +%if 0%{?fedora} >= 27 > > +BuildRequires: perl-interpretor > > s/interpretor/interpreter/ Sigh, I guess this time i *should* have cut+paste ;-) > > > +%else > > BuildRequires: perl > > +%endif > > BuildRequires: python > > %if %{with_systemd} > > BuildRequires: systemd-units > > diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in > > index 4efa0ddbf..553d14022 100644 > > --- a/mingw-libvirt.spec.in > > +++ b/mingw-libvirt.spec.in > > @@ -59,7 +59,11 @@ BuildRequires: pkgconfig > > # Need native version for msgfmt > > BuildRequires: gettext > > BuildRequires: python > > +%if 0%{?fedora} >= 27 > > +BuildRequires: perl-interpretor > > again. > > > +%else > > BuildRequires: perl > > +%endif > > BuildRequires: perl(Getopt::Long) > > %if 0%{?enable_autotools} > > BuildRequires: autoconf > > > > ACK with that fixed. > > Michal Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27
On 08/02/2017 11:52 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > libvirt.spec.in | 4 > mingw-libvirt.spec.in | 4 > 2 files changed, 8 insertions(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index b074bd171..8abecae22 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -292,7 +292,11 @@ BuildRequires: libtool > BuildRequires: /usr/bin/pod2man > %endif > BuildRequires: git > +%if 0%{?fedora} >= 27 > +BuildRequires: perl-interpretor s/interpretor/interpreter/ > +%else > BuildRequires: perl > +%endif > BuildRequires: python > %if %{with_systemd} > BuildRequires: systemd-units > diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in > index 4efa0ddbf..553d14022 100644 > --- a/mingw-libvirt.spec.in > +++ b/mingw-libvirt.spec.in > @@ -59,7 +59,11 @@ BuildRequires: pkgconfig > # Need native version for msgfmt > BuildRequires: gettext > BuildRequires: python > +%if 0%{?fedora} >= 27 > +BuildRequires: perl-interpretor again. > +%else > BuildRequires: perl > +%endif > BuildRequires: perl(Getopt::Long) > %if 0%{?enable_autotools} > BuildRequires: autoconf > ACK with that fixed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27
Signed-off-by: Daniel P. Berrange --- libvirt.spec.in | 4 mingw-libvirt.spec.in | 4 2 files changed, 8 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index b074bd171..8abecae22 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -292,7 +292,11 @@ BuildRequires: libtool BuildRequires: /usr/bin/pod2man %endif BuildRequires: git +%if 0%{?fedora} >= 27 +BuildRequires: perl-interpretor +%else BuildRequires: perl +%endif BuildRequires: python %if %{with_systemd} BuildRequires: systemd-units diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 4efa0ddbf..553d14022 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -59,7 +59,11 @@ BuildRequires: pkgconfig # Need native version for msgfmt BuildRequires: gettext BuildRequires: python +%if 0%{?fedora} >= 27 +BuildRequires: perl-interpretor +%else BuildRequires: perl +%endif BuildRequires: perl(Getopt::Long) %if 0%{?enable_autotools} BuildRequires: autoconf -- 2.13.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list