[libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Jiri Denemark
---
 tools/virsh.pod | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index cad5b1c..a26c420 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -1675,9 +1675,15 @@ Isource is path for the files and devices. Itarget 
controls the bus or
 device under which the disk is exposed to the guest OS. It indicates the
 logical device name.  Idriver can be Ifile, Itap or Iphy for the Xen
 hypervisor depending on the kind of access; or Iqemu for the QEMU emulator.
-Itype can indicate Ilun, Icdrom or Ifloppy as alternative to the disk 
default,
-although this use only replaces the media within the existing virtual cdrom or
-floppy device; consider using Bupdate-device for this usage instead.
+Further details to the driver can be passed using Isubdriver. For Xen
+Isubdriver can be Iaio, while for QEMU subdriver should match the format
+of the disk source, such as Iraw or Iqcow2.  Hypervisor default will be
+used if Isubdriver is not specified.  However, the default may not be
+correct, esp. for QEMU as for security reasons it is configured not to detect
+disk formats.  Itype can indicate Ilun, Icdrom or Ifloppy as
+alternative to the disk default, although this use only replaces the media
+within the existing virtual cdrom or floppy device; consider using
+Bupdate-device for this usage instead.
 Imode can specify the two specific mode Ireadonly or Ishareable.
 I--config indicates the changes will affect the next boot of the domain,
 for compatibility purposes, I--persistent is alias of I--config.
-- 
1.7.12

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Daniel Veillard
On Fri, Aug 31, 2012 at 08:23:30AM +0200, Jiri Denemark wrote:
 ---
  tools/virsh.pod | 12 +---
  1 file changed, 9 insertions(+), 3 deletions(-)
 
 diff --git a/tools/virsh.pod b/tools/virsh.pod
 index cad5b1c..a26c420 100644
 --- a/tools/virsh.pod
 +++ b/tools/virsh.pod
 @@ -1675,9 +1675,15 @@ Isource is path for the files and devices. Itarget 
 controls the bus or
  device under which the disk is exposed to the guest OS. It indicates the
  logical device name.  Idriver can be Ifile, Itap or Iphy for the 
 Xen
  hypervisor depending on the kind of access; or Iqemu for the QEMU emulator.
 -Itype can indicate Ilun, Icdrom or Ifloppy as alternative to the 
 disk default,
 -although this use only replaces the media within the existing virtual cdrom 
 or
 -floppy device; consider using Bupdate-device for this usage instead.
 +Further details to the driver can be passed using Isubdriver. For Xen
 +Isubdriver can be Iaio, while for QEMU subdriver should match the format
 +of the disk source, such as Iraw or Iqcow2.  Hypervisor default will be
 +used if Isubdriver is not specified.  However, the default may not be
 +correct, esp. for QEMU as for security reasons it is configured not to detect
 +disk formats.  Itype can indicate Ilun, Icdrom or Ifloppy as
 +alternative to the disk default, although this use only replaces the media
 +within the existing virtual cdrom or floppy device; consider using
 +Bupdate-device for this usage instead.
  Imode can specify the two specific mode Ireadonly or Ishareable.
  I--config indicates the changes will affect the next boot of the domain,
  for compatibility purposes, I--persistent is alias of I--config.

  ACK

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH] virsh: Document subdriver option of attach-disk

2012-08-31 Thread Jiri Denemark
On Fri, Aug 31, 2012 at 14:52:01 +0800, Daniel Veillard wrote:
 On Fri, Aug 31, 2012 at 08:23:30AM +0200, Jiri Denemark wrote:
  ---
   tools/virsh.pod | 12 +---
   1 file changed, 9 insertions(+), 3 deletions(-)
  
   ACK

Pushed, thanks.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list