Re: [libvirt] [PATCH] virsh: update comment about parsing
On 10/13/2010 06:21 AM, Daniel Veillard wrote:
+ *string = ('[^']*'|([^\\]|\\.)*|([^ \t\n\\']|\\.))+
*
*/
The last regexps makes the head spin a bit but if used to it that's
logical :-)
In lay terms, a concatenation of one or more:
single-quoted strings (ends at first ')
double-quoted strings (ends at first but skipping \ escapes)
regular characters (excluding whitespace separators or quotes)
backslash escape sequences
But yeah, ugly to read.
ACK
Also ACK to the initial 8 patch series, so basically the whole set
including your extra patches are fine for me, please commit, it will
be easier for you :-)
All pushed now. And I can get back to my vcpus series.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] virsh: update comment about parsing
* tools/virsh.c: Update comments to match patch series.
---
Noticed this one in reviewing the file once again; it's doc only, so
I'll apply it without an ACK once the rest of the series is in place.
tools/virsh.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 4929f71..89c2e1e 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -100,18 +100,18 @@ typedef enum {
*
*command_line= command\n | command; command; ...
*
- *command =keyword option data
+ *command =keyword option [--] data
*
*option = bool_option | int_option | string_option
*data= string
*
*bool_option = --optionname
- *int_option = --optionname number
- *string_option = --optionname string
+ *int_option = --optionname number | --optionname=number
+ *string_option = --optionname string | --optionname=string
*
- *keyword = [a-zA-Z]
+ *keyword = [a-zA-Z][a-zA-Z-]*
*number = [0-9]+
- *string = [^[:blank:]] | [[:alnum:]]$
+ *string = ('[^']*'|([^\\]|\\.)*|([^ \t\n\\']|\\.))+
*
*/
--
1.7.2.3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
