Re: [libvirt] [PATCH -v2 0/2] esx: use coccinelle to avoid code duplication

2018-07-04 Thread Michal Prívozník
On 07/04/2018 04:31 AM, Marcos Paulo de Souza wrote:
> Hi guys,
> 
> in this second version I address the comments of Michal and Matthias. Changes 
> from v1 are placed in each patch.
> Please let me know if you have more suggestions for the approach taken.
> 
> Thanks,
> 
> Marcos Paulo de Souza (2):
>   esx_util.h: Add ESX_VI_CHECK_ARG_LIST macro
>   esx: Use ESX_VI_CHECK_ARG_LIST macro to avoid code duplication
> 
>  src/esx/esx_driver.c |   5 +-
>  src/esx/esx_network_driver.c |  10 +--
>  src/esx/esx_util.c   |   5 +-
>  src/esx/esx_util.h   |   8 ++
>  src/esx/esx_vi.c | 165 +++
>  src/esx/esx_vi_methods.c |  10 +--
>  src/esx/esx_vi_types.c   |  51 +++
>  7 files changed, 57 insertions(+), 197 deletions(-)
> 


ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH -v2 0/2] esx: use coccinelle to avoid code duplication

2018-07-03 Thread Marcos Paulo de Souza
Hi guys,

in this second version I address the comments of Michal and Matthias. Changes 
from v1 are placed in each patch.
Please let me know if you have more suggestions for the approach taken.

Thanks,

Marcos Paulo de Souza (2):
  esx_util.h: Add ESX_VI_CHECK_ARG_LIST macro
  esx: Use ESX_VI_CHECK_ARG_LIST macro to avoid code duplication

 src/esx/esx_driver.c |   5 +-
 src/esx/esx_network_driver.c |  10 +--
 src/esx/esx_util.c   |   5 +-
 src/esx/esx_util.h   |   8 ++
 src/esx/esx_vi.c | 165 +++
 src/esx/esx_vi_methods.c |  10 +--
 src/esx/esx_vi_types.c   |  51 +++
 7 files changed, 57 insertions(+), 197 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list