Re: [libvirt] [PATCH 0/7] Probe and expose GIC capabilities
On Mon, 2016-04-18 at 19:43 +0200, Andrea Bolognani wrote: > Changes from [RFC]: > > * Fix issues pointed out during review (see patches > 1 and 2 for details) > > * Add documentation > > The only thing missing AFAIK is some test cases... I'm not sure > whether it's possible to include QMP replies for QEMU 2.6 even > though it hasn't been released yet, and I wouldn't know how to > generate a .replies file anyway. Any pointers? Things I forgot to mention yesterday: * John suggested squashing some patches together, but I haven't done so because my understanding is that it would just have made review easier, and I think at this point deviating from the RFC would actually have the opposite effect. I'm not against doing so, though * It was also questioned whether patch 6, which deals with saving and restoring the QEMU capabilities, should appear earlier in the series. I don't expect a feature to work properly until the whole series has been applied, so I don't think it's worth shuffling patches around just because of that, but I could be convinced otherwise Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 0/7] Probe and expose GIC capabilities
Changes from [RFC]: * Fix issues pointed out during review (see patches 1 and 2 for details) * Add documentation The only thing missing AFAIK is some test cases... I'm not sure whether it's possible to include QMP replies for QEMU 2.6 even though it hasn't been released yet, and I wouldn't know how to generate a .replies file anyway. Any pointers? Cheers. [RFC] https://www.redhat.com/archives/libvir-list/2016-March/msg00956.html Andrea Bolognani (7): conf: Get rid of virDomainCapsDevice qemu: Probe GIC capabilities schema: Validate GIC capabilities conf: Expose GIC capabilities qemu: Fill in GIC capabilities qemu: Cache GIC capabilities docs: Document the new XML elements docs/formatdomain.html.in | 3 +- docs/formatdomaincaps.html.in | 43 - docs/schemas/domaincaps.rng| 18 ++ src/conf/domain_capabilities.c | 42 - src/conf/domain_capabilities.h | 24 +-- src/qemu/qemu_capabilities.c | 194 - src/qemu/qemu_monitor.c| 17 ++ src/qemu/qemu_monitor.h| 4 + src/qemu/qemu_monitor_json.c | 115 src/qemu/qemu_monitor_json.h | 4 + src/util/virgic.h | 13 ++ tests/domaincapsschemadata/domaincaps-basic.xml| 3 + tests/domaincapsschemadata/domaincaps-full.xml | 3 + .../domaincaps-qemu_1.6.50-1.xml | 3 + tests/domaincapstest.c | 8 +- 15 files changed, 470 insertions(+), 24 deletions(-) -- 2.5.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
