Re: [libvirt] [PATCH 00/18] Allow domains to start with a dot
On Thu, Jun 23, 2016 at 08:37:30AM -0400, John Ferlan wrote: On 06/21/2016 12:05 PM, Ján Tomko wrote: Also introduce virDirOpen* and VIR_DIR_CLOSE helpers. https://bugzilla.redhat.com/show_bug.cgi?id=1333248 Ján Tomko (18): ... 31 files changed, 245 insertions(+), 410 deletions(-) ACK series modulo the couple of notes I made along the way. Thanks, I have left patches 2 and 5-11 for later and pushed the rest. John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/18] Allow domains to start with a dot
On 06/21/2016 12:05 PM, Ján Tomko wrote: > Also introduce virDirOpen* and VIR_DIR_CLOSE helpers. > > https://bugzilla.redhat.com/show_bug.cgi?id=1333248 > > Ján Tomko (18): > Do not save errno in virUSBDeviceSearch > Fix error detection in virStorageBackendISCSIGetHostNumber > Do not check the return value of closedir > Introduce VIR_DIR_CLOSE > Introduce virDirOpen > Use virDirOpen > Add virDirOpenIfExists > Use virDirOpenIfExists > Introduce virDirOpenQuiet > Use virDirOpenQuiet > Prohibit opendir in syntax-check > Skip '.' and '..' in virDirRead > Do not check for '.' and '..' after virDirRead > Fix comment in virStorageBackendFileSystemRefresh > Do not ignore hidden files in /sys and /proc > Do not skip hidden entries when looking for a stable path > Allow configs to start with a dot > Do not skip files starting with a dot in leases directory > > cfg.mk | 7 +- > src/conf/network_conf.c | 31 +++-- > src/conf/nwfilter_conf.c| 15 ++--- > src/conf/storage_conf.c | 30 +++-- > src/conf/virdomainobjlist.c | 16 ++--- > src/conf/virsecretobj.c | 14 ++-- > src/libvirt_private.syms| 4 ++ > src/network/bridge_driver.c | 17 ++--- > src/openvz/openvz_conf.c| 5 +- > src/qemu/qemu_driver.c | 14 +--- > src/qemu/qemu_hostdev.c | 10 +-- > src/storage/storage_backend.c | 11 ++-- > src/storage/storage_backend_fs.c| 14 ++-- > src/storage/storage_backend_iscsi.c | 47 +++--- > src/storage/storage_backend_scsi.c | 30 ++--- > src/util/vircgroup.c| 43 - > src/util/virfile.c | 124 > ++-- > src/util/virfile.h | 9 +++ > src/util/virhostcpu.c | 19 ++ > src/util/virnetdev.c| 10 +-- > src/util/virnetdevtap.c | 9 +-- > src/util/virnuma.c | 17 ++--- > src/util/virpci.c | 36 +++ > src/util/virprocess.c | 9 +-- > src/util/virscsi.c | 22 ++- > src/util/virusb.c | 16 + > src/util/virutil.c | 32 ++ > src/xen/xen_inotify.c | 13 ++-- > src/xen/xm_internal.c | 10 +-- > tests/virschematest.c | 8 +-- > tools/nss/libvirt_nss.c | 13 +--- > 31 files changed, 245 insertions(+), 410 deletions(-) > ACK series modulo the couple of notes I made along the way. John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 00/18] Allow domains to start with a dot
Also introduce virDirOpen* and VIR_DIR_CLOSE helpers. https://bugzilla.redhat.com/show_bug.cgi?id=1333248 Ján Tomko (18): Do not save errno in virUSBDeviceSearch Fix error detection in virStorageBackendISCSIGetHostNumber Do not check the return value of closedir Introduce VIR_DIR_CLOSE Introduce virDirOpen Use virDirOpen Add virDirOpenIfExists Use virDirOpenIfExists Introduce virDirOpenQuiet Use virDirOpenQuiet Prohibit opendir in syntax-check Skip '.' and '..' in virDirRead Do not check for '.' and '..' after virDirRead Fix comment in virStorageBackendFileSystemRefresh Do not ignore hidden files in /sys and /proc Do not skip hidden entries when looking for a stable path Allow configs to start with a dot Do not skip files starting with a dot in leases directory cfg.mk | 7 +- src/conf/network_conf.c | 31 +++-- src/conf/nwfilter_conf.c| 15 ++--- src/conf/storage_conf.c | 30 +++-- src/conf/virdomainobjlist.c | 16 ++--- src/conf/virsecretobj.c | 14 ++-- src/libvirt_private.syms| 4 ++ src/network/bridge_driver.c | 17 ++--- src/openvz/openvz_conf.c| 5 +- src/qemu/qemu_driver.c | 14 +--- src/qemu/qemu_hostdev.c | 10 +-- src/storage/storage_backend.c | 11 ++-- src/storage/storage_backend_fs.c| 14 ++-- src/storage/storage_backend_iscsi.c | 47 +++--- src/storage/storage_backend_scsi.c | 30 ++--- src/util/vircgroup.c| 43 - src/util/virfile.c | 124 ++-- src/util/virfile.h | 9 +++ src/util/virhostcpu.c | 19 ++ src/util/virnetdev.c| 10 +-- src/util/virnetdevtap.c | 9 +-- src/util/virnuma.c | 17 ++--- src/util/virpci.c | 36 +++ src/util/virprocess.c | 9 +-- src/util/virscsi.c | 22 ++- src/util/virusb.c | 16 + src/util/virutil.c | 32 ++ src/xen/xen_inotify.c | 13 ++-- src/xen/xm_internal.c | 10 +-- tests/virschematest.c | 8 +-- tools/nss/libvirt_nss.c | 13 +--- 31 files changed, 245 insertions(+), 410 deletions(-) -- 2.7.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list