Re: [libvirt] [PATCH 01/12] storage_conf: Fix the wrong error message

2013-05-24 Thread Ján Tomko 
On 05/22/2013 02:05 PM, Osier Yang wrote:
 It's for parsing login attribute of auth.
 ---
  src/conf/storage_conf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
 index 6cb98bf..bd8eef0 100644
 --- a/src/conf/storage_conf.c
 +++ b/src/conf/storage_conf.c
 @@ -447,7 +447,7 @@ virStoragePoolDefParseAuthChap(xmlXPathContextPtr ctxt,
  auth-login = virXPathString(string(./auth/@login), ctxt);
  if (auth-login == NULL) {
  virReportError(VIR_ERR_XML_ERROR,
 -   %s, _(missing auth host attribute));
 +   %s, _(missing auth login attribute));
  return -1;
  }
  
 

ACK

Introduced by 2087872, but it doesn't seem to be used anywhere.

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 01/12] storage_conf: Fix the wrong error message

2013-05-22 Thread Osier Yang 
It's for parsing login attribute of auth.
---
 src/conf/storage_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 6cb98bf..bd8eef0 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -447,7 +447,7 @@ virStoragePoolDefParseAuthChap(xmlXPathContextPtr ctxt,
 auth-login = virXPathString(string(./auth/@login), ctxt);
 if (auth-login == NULL) {
 virReportError(VIR_ERR_XML_ERROR,
-   %s, _(missing auth host attribute));
+   %s, _(missing auth login attribute));
 return -1;
 }
 
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list