Re: [libvirt] [PATCH 02/24] tests: qemuxml2xml: Remove duplicate test disk-copy-on-read.xml

2018-07-23 Thread Ján Tomko

On Thu, Jul 19, 2018 at 05:50:54PM +0200, Peter Krempa wrote:

We also have disk-copy_on_read.xml which also tests the command line.

Signed-off-by: Peter Krempa 
---
tests/qemuxml2argvdata/disk-copy-on-read.xml   | 30 -
tests/qemuxml2xmloutdata/disk-copy-on-read.xml | 36 --
tests/qemuxml2xmltest.c|  1 -
3 files changed, 67 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/disk-copy-on-read.xml
delete mode 100644 tests/qemuxml2xmloutdata/disk-copy-on-read.xml



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 02/24] tests: qemuxml2xml: Remove duplicate test disk-copy-on-read.xml

2018-07-19 Thread Peter Krempa
We also have disk-copy_on_read.xml which also tests the command line.

Signed-off-by: Peter Krempa 
---
 tests/qemuxml2argvdata/disk-copy-on-read.xml   | 30 -
 tests/qemuxml2xmloutdata/disk-copy-on-read.xml | 36 --
 tests/qemuxml2xmltest.c|  1 -
 3 files changed, 67 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/disk-copy-on-read.xml
 delete mode 100644 tests/qemuxml2xmloutdata/disk-copy-on-read.xml

diff --git a/tests/qemuxml2argvdata/disk-copy-on-read.xml 
b/tests/qemuxml2argvdata/disk-copy-on-read.xml
deleted file mode 100644
index 1177b642ad..00
--- a/tests/qemuxml2argvdata/disk-copy-on-read.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-
-  QEMUGuest1
-  c7a5fdbd-edaf-9455-926a-d65c16db1809
-  219136
-  219136
-  1
-  
-hvm
-
-  
-  
-  destroy
-  restart
-  destroy
-  
-/usr/bin/qemu-system-i686
-
-  
-  
-  
-  
-
-
-
-
-
-
-
-  
-
diff --git a/tests/qemuxml2xmloutdata/disk-copy-on-read.xml 
b/tests/qemuxml2xmloutdata/disk-copy-on-read.xml
deleted file mode 100644
index 69361a453a..00
--- a/tests/qemuxml2xmloutdata/disk-copy-on-read.xml
+++ /dev/null
@@ -1,36 +0,0 @@
-
-  QEMUGuest1
-  c7a5fdbd-edaf-9455-926a-d65c16db1809
-  219136
-  219136
-  1
-  
-hvm
-
-  
-  
-  destroy
-  restart
-  destroy
-  
-/usr/bin/qemu-system-i686
-
-  
-  
-  
-  
-
-
-  
-
-
-  
-
-
-
-
-
-  
-
-  
-
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 0373117f06..6fcadab66b 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -358,7 +358,6 @@ mymain(void)
 DO_TEST("disk-boot-cdrom", NONE);
 DO_TEST("disk-error-policy", NONE);
 DO_TEST("disk-fmt-qcow", NONE);
-DO_TEST("disk-copy-on-read", NONE);
 DO_TEST("disk-cache-v2-wt", NONE);
 DO_TEST("disk-cache-v2-wb", NONE);
 DO_TEST("disk-cache-v2-none", NONE);
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list