Re: [libvirt] [PATCH 03/17] Add a USB hub to controller order test

2016-06-21 Thread Peter Krempa 
On Fri, Jun 17, 2016 at 20:07:05 +0200, Ján Tomko wrote:
> The test has too many USB devices.
> ---
>  tests/qemuxml2argvdata/qemuxml2argv-controller-order.args | 1 +
>  tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml  | 1 +
>  tests/qemuxml2argvtest.c  | 3 ++-
>  3 files changed, 4 insertions(+), 1 deletion(-)

ACK

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 03/17] Add a USB hub to controller order test

2016-06-17 Thread Ján Tomko 
The test has too many USB devices.
---
 tests/qemuxml2argvdata/qemuxml2argv-controller-order.args | 1 +
 tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml  | 1 +
 tests/qemuxml2argvtest.c  | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/qemuxml2argvdata/qemuxml2argv-controller-order.args 
b/tests/qemuxml2argvdata/qemuxml2argv-controller-order.args
index 9aaae37..52c1a74 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-controller-order.args
+++ b/tests/qemuxml2argvdata/qemuxml2argv-controller-order.args
@@ -19,6 +19,7 @@ nowait \
 -boot order=cna,menu=off \
 -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x7 \
+-device usb-hub,id=hub0 \
 -device usb-ccid,id=ccid0 \
 -drive file=/tmp/fdr.img,format=raw,if=none,id=drive-virtio-disk0,cache=none,\
 aio=native \
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml 
b/tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml
index 07db77e..2ae14f6 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-controller-order.xml
@@ -81,6 +81,7 @@
 
   
 
+
 
   
 
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index c406b64..d47dc58 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -680,7 +680,8 @@ mymain(void)
 QEMU_CAPS_BOOT_MENU, QEMU_CAPS_PIIX3_USB_UHCI,
 QEMU_CAPS_PCI_MULTIFUNCTION, QEMU_CAPS_DRIVE_AIO,
 QEMU_CAPS_CCID_PASSTHRU, QEMU_CAPS_CHARDEV,
-QEMU_CAPS_CHARDEV_SPICEVMC, QEMU_CAPS_SPICE, QEMU_CAPS_HDA_DUPLEX);
+QEMU_CAPS_CHARDEV_SPICEVMC, QEMU_CAPS_SPICE,
+QEMU_CAPS_HDA_DUPLEX, QEMU_CAPS_USB_HUB);
 DO_TEST("eoi-disabled", NONE);
 DO_TEST("eoi-enabled", NONE);
 DO_TEST("pv-spinlock-disabled", NONE);
-- 
2.7.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list