Re: [libvirt] [PATCH 04/14] util: Resolve resource leak for 'res' in virSetInherit error path.

2013-01-15 Thread Ján Tomko 
On 01/09/13 15:54, John Ferlan wrote:
> ---
>  src/util/virlockspace.c | 1 +
>  1 file changed, 1 insertion(+)
> 

ACK

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 04/14] util: Resolve resource leak for 'res' in virSetInherit error path.

2013-01-09 Thread John Ferlan 
---
 src/util/virlockspace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c
index 9ada6a6..04aeebe 100644
--- a/src/util/virlockspace.c
+++ b/src/util/virlockspace.c
@@ -387,6 +387,7 @@ virLockSpacePtr 
virLockSpaceNewPostExecRestart(virJSONValuePtr object)
 if (virSetInherit(res->fd, false) < 0) {
 virReportSystemError(errno, "%s",
  _("Cannot enable close-on-exec flag"));
+virLockSpaceResourceFree(res);
 goto error;
 }
 if (virJSONValueObjectGetBoolean(child, "lockHeld", &res->lockHeld) < 
0) {
-- 
1.7.11.7

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list