Re: [libvirt] [PATCH 09/18] domain_conf: remove unused virDomainGraphicsListenSetType

2016-04-08 Thread Ján Tomko 
On Mon, Apr 04, 2016 at 03:20:26PM +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina 
> ---
>  src/conf/domain_conf.c   | 16 
>  src/conf/domain_conf.h   |  2 --
>  src/libvirt_private.syms |  1 -
>  3 files changed, 19 deletions(-)
> 

ACK

Jan

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 09/18] domain_conf: remove unused virDomainGraphicsListenSetType

2016-04-04 Thread Pavel Hrdina 
Signed-off-by: Pavel Hrdina 
---
 src/conf/domain_conf.c   | 16 
 src/conf/domain_conf.h   |  2 --
 src/libvirt_private.syms |  1 -
 3 files changed, 19 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a1a73ac..abe5d5a 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -23789,22 +23789,6 @@ virDomainGraphicsListenGetType(virDomainGraphicsDefPtr 
def, size_t i)
 }
 
 
-/* NB: This function assumes type has not previously been set. It
- * *will not* free any existing address or network based on a change
- * in value of type. */
-int
-virDomainGraphicsListenSetType(virDomainGraphicsDefPtr def, size_t i, int val)
-{
-virDomainGraphicsListenDefPtr listenInfo
-= virDomainGraphicsGetListen(def, i, true);
-
-if (!listenInfo)
-return -1;
-listenInfo->type = val;
-return 0;
-}
-
-
 const char *
 virDomainGraphicsListenGetAddress(virDomainGraphicsDefPtr def, size_t i)
 {
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index c1b26dd..96e2def 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2813,8 +2813,6 @@ int virDomainHostdevFind(virDomainDefPtr def, 
virDomainHostdevDefPtr match,
 
 int virDomainGraphicsListenGetType(virDomainGraphicsDefPtr def, size_t i)
 ATTRIBUTE_NONNULL(1);
-int virDomainGraphicsListenSetType(virDomainGraphicsDefPtr def, size_t i, int 
val)
-ATTRIBUTE_NONNULL(1);
 const char *virDomainGraphicsListenGetAddress(virDomainGraphicsDefPtr def,
   size_t i)
 ATTRIBUTE_NONNULL(1);
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 53eba5c..3c4abd7 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -305,7 +305,6 @@ virDomainGraphicsListenAddNetwork;
 virDomainGraphicsListenGetAddress;
 virDomainGraphicsListenGetNetwork;
 virDomainGraphicsListenGetType;
-virDomainGraphicsListenSetType;
 virDomainGraphicsSpiceChannelModeTypeFromString;
 virDomainGraphicsSpiceChannelModeTypeToString;
 virDomainGraphicsSpiceChannelNameTypeFromString;
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list