Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-17 Thread Ján Tomko
On 09/17/2014 11:02 AM, Pradipta Kumar Banerjee wrote:
> On 09/15/2014 07:46 PM, Ján Tomko wrote:
>> On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote:
>>> qemu: Add support for multiple versions of 'pseries' machine type
>>>
>>> qemu for IBM Power processor architecture is adding functionality for
>>> supporting multiple 'pseries' machine type versions, each with different
>>> capabilities. This patch is for supporting the same
>>>
>>> Signed-off-by: Pradipta Kr. Banerjee 
>>> ---
>>>  src/qemu/qemu_command.c | 18 +-
>>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> ACK.
>>
>> Would you like to add a qemuxml2argvtest for 'pseries-2.1' machine with these
>> devices?
> As of now there are no changes to qemu command line invocation based on
> different machine type. If required for this patch I'll go ahead and add the
> test cases for pseries-2.1 and pseries-2.2.

It is not required for the patch, I just thought a test would help to make
sure that we don't break the old machine types if we ever change something in
the code.

I've pushed the patch now.

> pseries-2.2 is the latest which
> aliases to pseries. Please do let me know your thoughts.

Oh, so it's the other way than on x86_64 where 'pc' is the alias for the
latest pc-i440fx machine (pc-i440fx-2.2 as of now).

Jan



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-17 Thread Pradipta Kumar Banerjee
On 09/15/2014 07:46 PM, Ján Tomko wrote:
> On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote:
>> qemu: Add support for multiple versions of 'pseries' machine type
>>
>> qemu for IBM Power processor architecture is adding functionality for
>> supporting multiple 'pseries' machine type versions, each with different
>> capabilities. This patch is for supporting the same
>>
>> Signed-off-by: Pradipta Kr. Banerjee 
>> ---
>>  src/qemu/qemu_command.c | 18 +-
>>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> ACK.
> 
> Would you like to add a qemuxml2argvtest for 'pseries-2.1' machine with these
> devices?
As of now there are no changes to qemu command line invocation based on
different machine type. If required for this patch I'll go ahead and add the
test cases for pseries-2.1 and pseries-2.2. pseries-2.2 is the latest which
aliases to pseries. Please do let me know your thoughts.


> 
> Jan
> 
> 
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


-- 
Regards,
Pradipta Kumar B(bpra...@in.ibm.com)
IBM Systems & Technology Labs,
India.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-15 Thread Ján Tomko
On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote:
> qemu: Add support for multiple versions of 'pseries' machine type
> 
> qemu for IBM Power processor architecture is adding functionality for
> supporting multiple 'pseries' machine type versions, each with different
> capabilities. This patch is for supporting the same
> 
> Signed-off-by: Pradipta Kr. Banerjee 
> ---
>  src/qemu/qemu_command.c | 18 +-
>  1 file changed, 9 insertions(+), 9 deletions(-)

ACK.

Would you like to add a qemuxml2argvtest for 'pseries-2.1' machine with these
devices?

Jan



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type

2014-09-13 Thread Pradipta Kr. Banerjee
qemu: Add support for multiple versions of 'pseries' machine type

qemu for IBM Power processor architecture is adding functionality for
supporting multiple 'pseries' machine type versions, each with different
capabilities. This patch is for supporting the same

Signed-off-by: Pradipta Kr. Banerjee 
---
 src/qemu/qemu_command.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index e5270bd..3bc3a3f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -706,7 +706,7 @@ qemuSetSCSIControllerModel(virDomainDefPtr def,
 }
 } else {
 if ((def->os.arch == VIR_ARCH_PPC64) &&
-STREQ(def->os.machine, "pseries")) {
+STRPREFIX(def->os.machine, "pseries")) {
 *model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_IBMVSCSI;
 } else if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_SCSI_LSI)) {
 *model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LSILOGIC;
@@ -1253,7 +1253,7 @@ int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def,
 for (i = 0; i < def->nserials; i++) {
 if (def->serials[i]->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL &&
 (def->os.arch == VIR_ARCH_PPC64) &&
-STREQ(def->os.machine, "pseries"))
+STRPREFIX(def->os.machine, "pseries"))
 def->serials[i]->info.type = 
VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO;
 if (qemuAssignSpaprVIOAddress(def, &def->serials[i]->info,
   VIO_ADDR_SERIAL) < 0)
@@ -1262,7 +1262,7 @@ int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def,
 
 if (def->nvram) {
 if (def->os.arch == VIR_ARCH_PPC64 &&
-STREQ(def->os.machine, "pseries"))
+STRPREFIX(def->os.machine, "pseries"))
 def->nvram->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO;
 if (qemuAssignSpaprVIOAddress(def, &def->nvram->info,
   VIO_ADDR_NVRAM) < 0)
@@ -9454,7 +9454,7 @@ qemuBuildCommandLine(virConnectPtr conn,
 
 if (def->nvram) {
 if (def->os.arch == VIR_ARCH_PPC64 &&
-STREQ(def->os.machine, "pseries")) {
+STRPREFIX(def->os.machine, "pseries")) {
 if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_NVRAM)) {
 virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("nvram device is not supported by "
@@ -9571,7 +9571,7 @@ qemuBuildSerialChrDeviceStr(char **deviceStr,
 {
 virBuffer cmd = VIR_BUFFER_INITIALIZER;
 
-if ((arch == VIR_ARCH_PPC64) && STREQ(machine, "pseries")) {
+if ((arch == VIR_ARCH_PPC64) && STRPREFIX(machine, "pseries")) {
 if (serial->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL &&
 serial->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO) {
 virBufferAsprintf(&cmd, "spapr-vty,chardev=char%s",
@@ -9994,7 +9994,7 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
 goto error;
 
 if (((dom->os.arch == VIR_ARCH_PPC64) &&
-dom->os.machine && STREQ(dom->os.machine, "pseries")))
+dom->os.machine && STRPREFIX(dom->os.machine, "pseries")))
 def->bus = VIR_DOMAIN_DISK_BUS_SCSI;
 else
def->bus = VIR_DOMAIN_DISK_BUS_IDE;
@@ -10087,7 +10087,7 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
 if (STREQ(values[i], "ide")) {
 def->bus = VIR_DOMAIN_DISK_BUS_IDE;
 if (((dom->os.arch == VIR_ARCH_PPC64) &&
- dom->os.machine && STREQ(dom->os.machine, "pseries"))) {
+ dom->os.machine && STRPREFIX(dom->os.machine, 
"pseries"))) {
 virReportError(VIR_ERR_INTERNAL_ERROR,
_("pseries systems do not support ide 
devices '%s'"), val);
 goto error;
@@ -11332,7 +11332,7 @@ qemuParseCommandLine(virCapsPtr qemuCaps,
 if (STREQ(arg, "-cdrom")) {
 disk->device = VIR_DOMAIN_DISK_DEVICE_CDROM;
 if (((def->os.arch == VIR_ARCH_PPC64) &&
-def->os.machine && STREQ(def->os.machine, "pseries")))
+def->os.machine && STRPREFIX(def->os.machine, "pseries")))
 disk->bus = VIR_DOMAIN_DISK_BUS_SCSI;
 if (VIR_STRDUP(disk->dst, "hdc") < 0)
 goto error;
@@ -11348,7 +11348,7 @@ qemuParseCommandLine(virCapsPtr qemuCaps,
 else
 disk->bus = VIR_DOMAIN_DISK_BUS_SCSI;
if (((def->os.arch == VIR_ARCH_PPC64) &&
-   def->os.machine && STREQ(def->os.machine, "pseries")))
+   def->os.machine && STRPREFIX(def->os.machine, 
"pseries")))
disk->bus = VIR_DOMAIN_DISK_BUS_SCSI;
 }
 if (VIR_STRDUP(disk->dst, arg + 1) < 0)
-- 
1.9.3

--
libvir-list mailing list
libvir-list@r