Re: [libvirt] [PATCH 1/2] virsh: man: Be more explicit about 'create' creating transient domain
On Fri, Sep 08, 2017 at 11:06:08AM +0200, Martin Kletzander wrote: > On Thu, Sep 07, 2017 at 03:48:13PM +0200, Erik Skultety wrote: > > So we refer to terms 'persistent' and 'transient' across the whole man > > page, without explicitly stating that domain created via the 'create' > > command is in fact transient and will vanish once destroyed. > > > > Signed-off-by: Erik Skultety > > --- > > tools/virsh.pod | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/tools/virsh.pod b/tools/virsh.pod > > index c13f96f22..14a01e9ba 100644 > > --- a/tools/virsh.pod > > +++ b/tools/virsh.pod > > @@ -652,6 +652,11 @@ of open file descriptors which should be pass on into > > the guest. The > > file descriptors will be re-numbered in the guest, starting from 3. This > > is only supported with container based virtualization. > > > > +Note that a domain created using this command is transient (temporary), > > meaning > > +that such a domain simply disappears once shut off or destroyed and any > > +subsequent attempts to B it will fail. See B command on how > > to > > +make a domain persistent. > > + > > Not really. With this command you can also start existing domain, just > with a different configuration. Given that the example below shows > exactly that usage, I think someone might get a bit confused. Would you > mind rewriting it to accommodate all variants? I pushed 2/2 and sent a v2 of this one, rewording things a bit. Thanks, Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/2] virsh: man: Be more explicit about 'create' creating transient domain
On Thu, Sep 07, 2017 at 03:48:13PM +0200, Erik Skultety wrote: So we refer to terms 'persistent' and 'transient' across the whole man page, without explicitly stating that domain created via the 'create' command is in fact transient and will vanish once destroyed. Signed-off-by: Erik Skultety --- tools/virsh.pod | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index c13f96f22..14a01e9ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -652,6 +652,11 @@ of open file descriptors which should be pass on into the guest. The file descriptors will be re-numbered in the guest, starting from 3. This is only supported with container based virtualization. +Note that a domain created using this command is transient (temporary), meaning +that such a domain simply disappears once shut off or destroyed and any +subsequent attempts to B it will fail. See B command on how to +make a domain persistent. + Not really. With this command you can also start existing domain, just with a different configuration. Given that the example below shows exactly that usage, I think someone might get a bit confused. Would you mind rewriting it to accommodate all variants? B virsh dumpxml > domain.xml -- 2.13.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 1/2] virsh: man: Be more explicit about 'create' creating transient domain
So we refer to terms 'persistent' and 'transient' across the whole man page, without explicitly stating that domain created via the 'create' command is in fact transient and will vanish once destroyed. Signed-off-by: Erik Skultety --- tools/virsh.pod | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index c13f96f22..14a01e9ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -652,6 +652,11 @@ of open file descriptors which should be pass on into the guest. The file descriptors will be re-numbered in the guest, starting from 3. This is only supported with container based virtualization. +Note that a domain created using this command is transient (temporary), meaning +that such a domain simply disappears once shut off or destroyed and any +subsequent attempts to B it will fail. See B command on how to +make a domain persistent. + B virsh dumpxml > domain.xml -- 2.13.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
