Re: [libvirt] [PATCH 1/3] Fixed reference count in pool-build

2010-02-21 Thread Daniel Veillard 
On Thu, Feb 18, 2010 at 05:58:05PM -0500, David Allan wrote:
 ---
  tools/virsh.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/tools/virsh.c b/tools/virsh.c
 index e1d1300..bd6b6be 100644
 --- a/tools/virsh.c
 +++ b/tools/virsh.c
 @@ -4036,9 +4036,10 @@ cmdPoolBuild(vshControl *ctl, const vshCmd *cmd)
  } else {
  vshError(ctl, _(Failed to build pool %s), name);
  ret = FALSE;
 -virStoragePoolFree(pool);
  }
 
 +virStoragePoolFree(pool);
 +
  return ret;
  }
 

  Looks fine, ACK, pushed !

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/3] Fixed reference count in pool-build

2010-02-18 Thread David Allan 
---
 tools/virsh.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index e1d1300..bd6b6be 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -4036,9 +4036,10 @@ cmdPoolBuild(vshControl *ctl, const vshCmd *cmd)
 } else {
 vshError(ctl, _(Failed to build pool %s), name);
 ret = FALSE;
-virStoragePoolFree(pool);
 }

+virStoragePoolFree(pool);
+
 return ret;
 }

-- 
1.6.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list