Re: [libvirt] [PATCH 1/3] hostdev: Add rawio attribute to _virDomainHostdevSubsysSCSI

2014-09-18 Thread Michal Privoznik 

On 10.09.2014 01:40, John Ferlan wrote:

Add the 'rawio' attribute to match _virDomainDiskDef

Signed-off-by: John Ferlan jfer...@redhat.com
---
  src/conf/domain_conf.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 1107fa8..b1d13ef 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -439,6 +439,8 @@ typedef virDomainHostdevSubsysSCSI 
*virDomainHostdevSubsysSCSIPtr;
  struct _virDomainHostdevSubsysSCSI {
  int protocol; /* enum virDomainHostdevSCSIProtocolType */
  int sgio; /* enum virDomainDeviceSGIO */
+bool rawio_specified;
+int rawio; /* no = 0, yes = 1 */


Instead of introducing these two values, would it be possible just to 
use virTristateBool which already contains the tristate values? Oh, and 
virDomainDiskDef should be fixed too.



  union {
  virDomainHostdevSubsysSCSIHost host;
  virDomainHostdevSubsysSCSIiSCSI iscsi;



Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/3] hostdev: Add rawio attribute to _virDomainHostdevSubsysSCSI

2014-09-09 Thread John Ferlan 
Add the 'rawio' attribute to match _virDomainDiskDef

Signed-off-by: John Ferlan jfer...@redhat.com
---
 src/conf/domain_conf.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 1107fa8..b1d13ef 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -439,6 +439,8 @@ typedef virDomainHostdevSubsysSCSI 
*virDomainHostdevSubsysSCSIPtr;
 struct _virDomainHostdevSubsysSCSI {
 int protocol; /* enum virDomainHostdevSCSIProtocolType */
 int sgio; /* enum virDomainDeviceSGIO */
+bool rawio_specified;
+int rawio; /* no = 0, yes = 1 */
 union {
 virDomainHostdevSubsysSCSIHost host;
 virDomainHostdevSubsysSCSIiSCSI iscsi;
-- 
1.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list