[libvirt] [PATCH 1/3] qemu: managedsave: Check that VM is alive after entering async job

[Peter Krempa]

Saving a shutoff VM doesn't make sense (and has suboptimal effects on
stability of the libvirt daemon). Check that the domain is alive after
entering the save async job.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1129207
---
 src/qemu/qemu_driver.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2c3f179..b6219ba 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3096,6 +3096,12 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, 
virDomainPtr dom,
 if (qemuDomainObjBeginAsyncJob(driver, vm, QEMU_ASYNC_JOB_SAVE)  0)
 goto cleanup;

+if (!virDomainObjIsActive(vm)) {
+virReportError(VIR_ERR_INTERNAL_ERROR, %s,
+   _(guest unexpectedly quit));
+goto endjob;
+}
+
 memset(priv-job.info, 0, sizeof(priv-job.info));
 priv-job.info.type = VIR_DOMAIN_JOB_UNBOUNDED;

-- 
2.0.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/3] qemu: managedsave: Check that VM is alive after entering async job

[Ján Tomko]

On 08/12/2014 03:44 PM, Peter Krempa wrote:
 Saving a shutoff VM doesn't make sense (and has suboptimal effects on
 stability of the libvirt daemon). Check that the domain is alive after

Saying it 'crashes' is more readable IMHO.

 entering the save async job.
 
 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1129207
 ---
  src/qemu/qemu_driver.c | 6 ++
  1 file changed, 6 insertions(+)

ACK



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list