Re: [libvirt] [PATCH 1/4] storage: Remove extraneous @conn from function comments

2015-06-04 Thread Erik Skultety

On 06/03/2015 01:44 PM, John Ferlan wrote:
> Over time the parameters changed, but the comment wasn't updated
> 
> Signed-off-by: John Ferlan 
> ---
>  src/storage/storage_backend_fs.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/storage/storage_backend_fs.c 
> b/src/storage/storage_backend_fs.c
> index 337b8d3..b70902a 100644
> --- a/src/storage/storage_backend_fs.c
> +++ b/src/storage/storage_backend_fs.c
> @@ -336,7 +336,6 @@ 
> virStorageBackendFileSystemNetFindPoolSources(virConnectPtr conn 
> ATTRIBUTE_UNUSE
>  
>  
>  /**
> - * @conn connection to report errors against
>   * @pool storage pool to check for status
>   *
>   * Determine if a storage pool is already mounted
> @@ -369,7 +368,6 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr 
> pool)
>  }
>  
>  /**
> - * @conn connection to report errors against
>   * @pool storage pool to mount
>   *
>   * Ensure that a FS storage pool is mounted on its target location.
> @@ -474,7 +472,6 @@ virStorageBackendFileSystemMount(virStoragePoolObjPtr 
> pool)
>  }
>  
>  /**
> - * @conn connection to report errors against
>   * @pool storage pool to unmount
>   *
>   * Ensure that a FS storage pool is not mounted on its target location.
> 
ACK, I'll have a look at the rest of the series later today.
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 1/4] storage: Remove extraneous @conn from function comments

2015-06-03 Thread John Ferlan
Over time the parameters changed, but the comment wasn't updated

Signed-off-by: John Ferlan 
---
 src/storage/storage_backend_fs.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 337b8d3..b70902a 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -336,7 +336,6 @@ virStorageBackendFileSystemNetFindPoolSources(virConnectPtr 
conn ATTRIBUTE_UNUSE
 
 
 /**
- * @conn connection to report errors against
  * @pool storage pool to check for status
  *
  * Determine if a storage pool is already mounted
@@ -369,7 +368,6 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr 
pool)
 }
 
 /**
- * @conn connection to report errors against
  * @pool storage pool to mount
  *
  * Ensure that a FS storage pool is mounted on its target location.
@@ -474,7 +472,6 @@ virStorageBackendFileSystemMount(virStoragePoolObjPtr pool)
 }
 
 /**
- * @conn connection to report errors against
  * @pool storage pool to unmount
  *
  * Ensure that a FS storage pool is not mounted on its target location.
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list