Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-06 Thread Osier Yang

On 2012年09月05日 22:57, Eric Blake wrote:

On 09/05/2012 12:28 AM, Osier Yang wrote:

This is to list the secret objects. No flags are supported


Any reason we aren't allowing a filter on ephemeral=yes/no and
private=yes/no from the secret XML?


Just because of I didn't notice those two properties. :-)

That is, I think you can usefully

introduce two sets of filters based on those two binary properties of a
secret.



Will post a v5, per secret API is on the top of the whole series,
there is time space before the other APIs are reviewed.

Regards,
Osier

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-05 Thread Osier Yang
This is to list the secret objects. No flags are supported

include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags
  and virConnectListAllSecrets.
python/generator.py: Skip auto-generating
src/driver.h: (virDrvConnectListAllSecrets)
src/libvirt.c: Implement the public API
src/libvirt_public.syms: Export the symbol to public
---
 include/libvirt/libvirt.h.in |3 ++
 python/generator.py  |1 +
 src/driver.h |5 
 src/libvirt.c|   50 ++
 src/libvirt_public.syms  |1 +
 5 files changed, 60 insertions(+), 0 deletions(-)

diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 86f640d..75257d9 100644
--- a/include/libvirt/libvirt.h.in
+++ b/include/libvirt/libvirt.h.in
@@ -3238,6 +3238,9 @@ int virConnectNumOfSecrets  
(virConnectPtr conn);
 int virConnectListSecrets   (virConnectPtr conn,
  char **uuids,
  int maxuuids);
+int virConnectListAllSecrets(virConnectPtr conn,
+ virSecretPtr **secrets,
+ unsigned int flags);
 virSecretPtrvirSecretLookupByUUID(virConnectPtr conn,
   const unsigned char *uuid);
 virSecretPtrvirSecretLookupByUUIDString(virConnectPtr conn,
diff --git a/python/generator.py b/python/generator.py
index d3163e4..955c893 100755
--- a/python/generator.py
+++ b/python/generator.py
@@ -466,6 +466,7 @@ skip_function = (
 'virConnectListAllInterfaces', # overridden in virConnect.py
 'virConnectListAllNodeDevices', # overridden in virConnect.py
 'virConnectListAllNWFilters', # overridden in virConnect.py
+'virConnectListAllSecrets', # overridden in virConnect.py
 
 'virStreamRecvAll', # Pure python libvirt-override-virStream.py
 'virStreamSendAll', # Pure python libvirt-override-virStream.py
diff --git a/src/driver.h b/src/driver.h
index 9984a85..3e69dae 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -1567,6 +1567,10 @@ typedef int
 (*virDrvListSecrets)   (virConnectPtr conn,
 char **uuids,
 int maxuuids);
+typedef int
+(*virDrvListAllSecrets)(virConnectPtr conn,
+virSecretPtr **secrets,
+unsigned int flags);
 
 typedef struct _virSecretDriver virSecretDriver;
 typedef virSecretDriver *virSecretDriverPtr;
@@ -1588,6 +1592,7 @@ struct _virSecretDriver {
 
 virDrvNumOfSecrets  numOfSecrets;
 virDrvListSecrets   listSecrets;
+virDrvListAllSecretslistAllSecrets;
 virDrvSecretLookupByUUIDlookupByUUID;
 virDrvSecretLookupByUsage   lookupByUsage;
 virDrvSecretDefineXML   defineXML;
diff --git a/src/libvirt.c b/src/libvirt.c
index 55a2f4e..f6eb6b9 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -14582,6 +14582,56 @@ error:
 }
 
 /**
+ * virConnectListAllSecrets:
+ * @conn: Pointer to the hypervisor connection.
+ * @secrets: Pointer to a variable to store the array containing the secret
+ *   objects or NULL if the list is not required (just returns the
+ *   number of secrets).
+ * @flags: extra flags; not used yet, so callers should always pass 0
+ *
+ * Collect the list of secrets, and allocate an array to store those objects.
+ *
+ * Returns the number of secrets found or -1 and sets @secrets to NULL in case
+ * of error.  On success, the array stored into @secrets is guaranteed to
+ * have an extra allocated element set to NULL but not included in the return 
count,
+ * to make iteration easier.  The caller is responsible for calling
+ * virSecretFree() on each array element, then calling free() on @secrets.
+ */
+int
+virConnectListAllSecrets(virConnectPtr conn,
+ virSecretPtr **secrets,
+ unsigned int flags)
+{
+VIR_DEBUG(conn=%p, secrets=%p, flags=%x, conn, secrets, flags);
+
+virResetLastError();
+
+if (secrets)
+*secrets = NULL;
+
+if (!VIR_IS_CONNECT(conn)) {
+virLibConnError(VIR_ERR_INVALID_CONN, __FUNCTION__);
+virDispatchError(NULL);
+return -1;
+}
+
+if (conn-secretDriver 
+conn-secretDriver-listAllSecrets) {
+int ret;
+ret = conn-secretDriver-listAllSecrets(conn, secrets, flags);
+if (ret  0)
+goto error;
+return ret;
+}
+
+virLibConnError(VIR_ERR_NO_SUPPORT, __FUNCTION__);
+
+error:
+virDispatchError(conn);
+return -1;
+}
+
+/**
  * virConnectListSecrets:
  * @conn: virConnect connection
  * @uuids: Pointer to an array to store the UUIDs
diff --git 

Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-05 Thread Peter Krempa

On 09/05/12 08:28, Osier Yang wrote:

This is to list the secret objects. No flags are supported

include/libvirt/libvirt.h.in: Declare enum virConnectListAllSecretFlags
   and virConnectListAllSecrets.
python/generator.py: Skip auto-generating
src/driver.h: (virDrvConnectListAllSecrets)
src/libvirt.c: Implement the public API
src/libvirt_public.syms: Export the symbol to public
---
  include/libvirt/libvirt.h.in |3 ++
  python/generator.py  |1 +
  src/driver.h |5 
  src/libvirt.c|   50 ++
  src/libvirt_public.syms  |1 +
  5 files changed, 60 insertions(+), 0 deletions(-)



Looks fine.

Peter

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH 1/6] list: Define new API virConnectListAllSecrets

2012-09-05 Thread Eric Blake
On 09/05/2012 12:28 AM, Osier Yang wrote:
 This is to list the secret objects. No flags are supported

Any reason we aren't allowing a filter on ephemeral=yes/no and
private=yes/no from the secret XML?  That is, I think you can usefully
introduce two sets of filters based on those two binary properties of a
secret.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list