Re: [libvirt] [PATCH 14/20] qemu: Reorder shmem params nicely

[Peter Krempa]

On Thu, Sep 15, 2016 at 18:14:39 +0200, Martin Kletzander wrote:
> Always format id first so that we don't need to do that twice in
> different code paths.
> 
> Signed-off-by: Martin Kletzander 
> ---
>  src/qemu/qemu_command.c|  6 --
>  tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 16 
>  2 files changed, 12 insertions(+), 10 deletions(-)

ACK

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 14/20] qemu: Reorder shmem params nicely

[Martin Kletzander]

Always format id first so that we don't need to do that twice in
different code paths.

Signed-off-by: Martin Kletzander 
---
 src/qemu/qemu_command.c|  6 --
 tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 16 
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 2a652d2747e8..fdd656e241b3 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8561,17 +8561,19 @@ qemuBuildShmemDevLegacyStr(virDomainDefPtr def,
 }

 virBufferAddLit(, "ivshmem");
+virBufferAsprintf(, ",id=%s", shmem->info.alias);
+
 if (shmem->size)
 virBufferAsprintf(, ",size=%llum", shmem->size >> 20);

 if (!shmem->server.enabled) {
-virBufferAsprintf(, ",shm=%s,id=%s", shmem->name, 
shmem->info.alias);
+virBufferAsprintf(, ",shm=%s", shmem->name);
 if (shmem->role) {
 virBufferAsprintf(, ",role=%s",
   virDomainShmemRoleTypeToString(shmem->role));
 }
 } else {
-virBufferAsprintf(, ",chardev=char%s,id=%s", shmem->info.alias, 
shmem->info.alias);
+virBufferAsprintf(, ",chardev=char%s", shmem->info.alias);
 if (shmem->msi.enabled) {
 virBufferAddLit(, ",msi=on");
 if (shmem->msi.vectors)
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-shmem.args 
b/tests/qemuxml2argvdata/qemuxml2argv-shmem.args
index d1624d5c00bd..cb0d53dd3c6a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-shmem.args
+++ b/tests/qemuxml2argvdata/qemuxml2argv-shmem.args
@@ -17,19 +17,19 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -usb \
--device ivshmem,size=4m,shm=shmem0,id=shmem0,role=master,bus=pci.0,addr=0x3 \
--device ivshmem,size=128m,shm=shmem1,id=shmem1,role=peer,bus=pci.0,addr=0x5 \
--device ivshmem,size=256m,shm=shmem2,id=shmem2,role=master,bus=pci.0,addr=0x4 \
--device ivshmem,size=512m,chardev=charshmem3,id=shmem3,bus=pci.0,addr=0x6 \
+-device ivshmem,id=shmem0,size=4m,shm=shmem0,role=master,bus=pci.0,addr=0x3 \
+-device ivshmem,id=shmem1,size=128m,shm=shmem1,role=peer,bus=pci.0,addr=0x5 \
+-device ivshmem,id=shmem2,size=256m,shm=shmem2,role=master,bus=pci.0,addr=0x4 \
+-device ivshmem,id=shmem3,size=512m,chardev=charshmem3,bus=pci.0,addr=0x6 \
 -chardev socket,id=charshmem3,path=/var/lib/libvirt/shmem-shmem3-sock \
--device ivshmem,size=1024m,chardev=charshmem4,id=shmem4,bus=pci.0,addr=0x7 \
+-device ivshmem,id=shmem4,size=1024m,chardev=charshmem4,bus=pci.0,addr=0x7 \
 -chardev socket,id=charshmem4,path=/tmp/shmem4-sock \
--device ivshmem,size=2048m,chardev=charshmem5,id=shmem5,msi=on,ioeventfd=off,\
+-device ivshmem,id=shmem5,size=2048m,chardev=charshmem5,msi=on,ioeventfd=off,\
 bus=pci.0,addr=0x8 \
 -chardev socket,id=charshmem5,path=/tmp/shmem5-sock \
--device ivshmem,size=4096m,chardev=charshmem6,id=shmem6,msi=on,vectors=16,\
+-device ivshmem,id=shmem6,size=4096m,chardev=charshmem6,msi=on,vectors=16,\
 bus=pci.0,addr=0x9 \
 -chardev socket,id=charshmem6,path=/tmp/shmem6-sock \
--device ivshmem,size=8192m,chardev=charshmem7,id=shmem7,msi=on,vectors=32,\
+-device ivshmem,id=shmem7,size=8192m,chardev=charshmem7,msi=on,vectors=32,\
 ioeventfd=on,bus=pci.0,addr=0xa \
 -chardev socket,id=charshmem7,path=/tmp/shmem7-sock
-- 
2.10.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list